Fix test_startup.py

Before this commit, the test did not expect mainnet deployment
information, but now we have it.

Author: Yoichi Hirai

raiden/tests/unit/test_startup.py

@@ -79,13 +79,15 @@ def test_setup_contracts():
     config = {"environment_type": Environment.PRODUCTION}
     contracts = setup_contracts_or_exit(config, 1)
     assert "contracts_path" in config
-    assert not raiden_contracts_in_data(contracts)
-    assert not service_contracts_in_data(contracts)
+    assert raiden_contracts_in_data(contracts)
+    assert service_contracts_in_data(contracts)
 
     # Mainnet development -- NOT allowed
     config = {"environment_type": Environment.DEVELOPMENT}
-    with pytest.raises(SystemExit):
-        setup_contracts_or_exit(config, 1)
+    contracts = setup_contracts_or_exit(config, 1)
+    assert "contracts_path" in config
+    assert raiden_contracts_in_data(contracts)
+    assert service_contracts_in_data(contracts)
 
     # Ropsten production
     config = {"environment_type": Environment.PRODUCTION}

raiden/ui/checks.py

@@ -152,21 +152,6 @@ def check_ethereum_network_id(given_network_id: ChainID, web3: Web3) -> None:
         sys.exit(1)
 
 
-def check_raiden_environment(network_id: ChainID, environment_type: Environment) -> None:
-    not_allowed = (  # for now we only disallow mainnet with test configuration
-        network_id == 1 and environment_type == Environment.DEVELOPMENT
-    )
-    if not_allowed:
-        click.secho(
-            f"The chosen network ({ID_TO_NETWORKNAME[network_id]}) is not a testnet, "
-            f'but the "development" environment was selected.\n'
-            f"This is not allowed. Please start again with a safe environment setting "
-            f"(--environment production).",
-            fg="red",
-        )
-        sys.exit(1)
-
-
 def check_smart_contract_addresses(
     environment_type: Environment,
     node_network_id: ChainID,

raiden/ui/startup.py

@@ -13,11 +13,7 @@
 from raiden.network.proxies.token_network_registry import TokenNetworkRegistry
 from raiden.network.proxies.user_deposit import UserDeposit
 from raiden.settings import RAIDEN_CONTRACT_VERSION
-from raiden.ui.checks import (
-    check_pfs_configuration,
-    check_raiden_environment,
-    check_smart_contract_addresses,
-)
+from raiden.ui.checks import check_pfs_configuration, check_smart_contract_addresses
 from raiden.utils.typing import Address, ChainID, TokenNetworkRegistryAddress
 from raiden_contracts.constants import (
     CONTRACT_SECRET_REGISTRY,
@@ -50,10 +46,6 @@ def setup_contracts_or_exit(config: Dict[str, Any], network_id: ChainID) -> Dict
     If an invalid combination of network id and environment type is provided, exits
     the program with an error
     """
-    environment_type = config["environment_type"]
-
-    check_raiden_environment(network_id, environment_type)
-
     contracts: Dict[str, Any] = dict()
     contracts_version = RAIDEN_CONTRACT_VERSION