Skip to content

Commit 6b5b484

Browse files
palangoLefterisJP
authored andcommitted
Reduce Sphinx warnings
1 parent ca74c8f commit 6b5b484

File tree

5 files changed

+25
-51
lines changed

5 files changed

+25
-51
lines changed

docs/Makefile

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -52,50 +52,43 @@ clean:
5252

5353
.PHONY: html
5454
html:
55-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
5655
$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html
5756
@echo
5857
@echo "Build finished. The HTML pages are in $(BUILDDIR)/html."
5958

6059
.PHONY: dirhtml
6160
dirhtml:
62-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
6361
$(SPHINXBUILD) -b dirhtml $(ALLSPHINXOPTS) $(BUILDDIR)/dirhtml
6462
@echo
6563
@echo "Build finished. The HTML pages are in $(BUILDDIR)/dirhtml."
6664

6765
.PHONY: singlehtml
6866
singlehtml:
69-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
7067
$(SPHINXBUILD) -b singlehtml $(ALLSPHINXOPTS) $(BUILDDIR)/singlehtml
7168
@echo
7269
@echo "Build finished. The HTML page is in $(BUILDDIR)/singlehtml."
7370

7471
.PHONY: pickle
7572
pickle:
76-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
7773
$(SPHINXBUILD) -b pickle $(ALLSPHINXOPTS) $(BUILDDIR)/pickle
7874
@echo
7975
@echo "Build finished; now you can process the pickle files."
8076

8177
.PHONY: json
8278
json:
83-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
8479
$(SPHINXBUILD) -b json $(ALLSPHINXOPTS) $(BUILDDIR)/json
8580
@echo
8681
@echo "Build finished; now you can process the JSON files."
8782

8883
.PHONY: htmlhelp
8984
htmlhelp:
90-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
9185
$(SPHINXBUILD) -b htmlhelp $(ALLSPHINXOPTS) $(BUILDDIR)/htmlhelp
9286
@echo
9387
@echo "Build finished; now you can run HTML Help Workshop with the" \
9488
".hhp project file in $(BUILDDIR)/htmlhelp."
9589

9690
.PHONY: qthelp
9791
qthelp:
98-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
9992
$(SPHINXBUILD) -b qthelp $(ALLSPHINXOPTS) $(BUILDDIR)/qthelp
10093
@echo
10194
@echo "Build finished; now you can run "qcollectiongenerator" with the" \
@@ -106,7 +99,6 @@ qthelp:
10699

107100
.PHONY: applehelp
108101
applehelp:
109-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
110102
$(SPHINXBUILD) -b applehelp $(ALLSPHINXOPTS) $(BUILDDIR)/applehelp
111103
@echo
112104
@echo "Build finished. The help book is in $(BUILDDIR)/applehelp."
@@ -116,7 +108,6 @@ applehelp:
116108

117109
.PHONY: devhelp
118110
devhelp:
119-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
120111
$(SPHINXBUILD) -b devhelp $(ALLSPHINXOPTS) $(BUILDDIR)/devhelp
121112
@echo
122113
@echo "Build finished."
@@ -127,21 +118,18 @@ devhelp:
127118

128119
.PHONY: epub
129120
epub:
130-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
131121
$(SPHINXBUILD) -b epub $(ALLSPHINXOPTS) $(BUILDDIR)/epub
132122
@echo
133123
@echo "Build finished. The epub file is in $(BUILDDIR)/epub."
134124

135125
.PHONY: epub3
136126
epub3:
137-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
138127
$(SPHINXBUILD) -b epub3 $(ALLSPHINXOPTS) $(BUILDDIR)/epub3
139128
@echo
140129
@echo "Build finished. The epub3 file is in $(BUILDDIR)/epub3."
141130

142131
.PHONY: latex
143132
latex:
144-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
145133
$(SPHINXBUILD) -b latex $(ALLSPHINXOPTS) $(BUILDDIR)/latex
146134
@echo
147135
@echo "Build finished; the LaTeX files are in $(BUILDDIR)/latex."
@@ -150,37 +138,32 @@ latex:
150138

151139
.PHONY: latexpdf
152140
latexpdf:
153-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
154141
$(SPHINXBUILD) -b latex $(ALLSPHINXOPTS) $(BUILDDIR)/latex
155142
@echo "Running LaTeX files through pdflatex..."
156143
$(MAKE) -C $(BUILDDIR)/latex all-pdf
157144
@echo "pdflatex finished; the PDF files are in $(BUILDDIR)/latex."
158145

159146
.PHONY: latexpdfja
160147
latexpdfja:
161-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
162148
$(SPHINXBUILD) -b latex $(ALLSPHINXOPTS) $(BUILDDIR)/latex
163149
@echo "Running LaTeX files through platex and dvipdfmx..."
164150
$(MAKE) -C $(BUILDDIR)/latex all-pdf-ja
165151
@echo "pdflatex finished; the PDF files are in $(BUILDDIR)/latex."
166152

167153
.PHONY: text
168154
text:
169-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
170155
$(SPHINXBUILD) -b text $(ALLSPHINXOPTS) $(BUILDDIR)/text
171156
@echo
172157
@echo "Build finished. The text files are in $(BUILDDIR)/text."
173158

174159
.PHONY: man
175160
man:
176-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
177161
$(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(BUILDDIR)/man
178162
@echo
179163
@echo "Build finished. The manual pages are in $(BUILDDIR)/man."
180164

181165
.PHONY: texinfo
182166
texinfo:
183-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
184167
$(SPHINXBUILD) -b texinfo $(ALLSPHINXOPTS) $(BUILDDIR)/texinfo
185168
@echo
186169
@echo "Build finished. The Texinfo files are in $(BUILDDIR)/texinfo."
@@ -189,65 +172,56 @@ texinfo:
189172

190173
.PHONY: info
191174
info:
192-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
193175
$(SPHINXBUILD) -b texinfo $(ALLSPHINXOPTS) $(BUILDDIR)/texinfo
194176
@echo "Running Texinfo files through makeinfo..."
195177
make -C $(BUILDDIR)/texinfo info
196178
@echo "makeinfo finished; the Info files are in $(BUILDDIR)/texinfo."
197179

198180
.PHONY: gettext
199181
gettext:
200-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
201182
$(SPHINXBUILD) -b gettext $(I18NSPHINXOPTS) $(BUILDDIR)/locale
202183
@echo
203184
@echo "Build finished. The message catalogs are in $(BUILDDIR)/locale."
204185

205186
.PHONY: changes
206187
changes:
207-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
208188
$(SPHINXBUILD) -b changes $(ALLSPHINXOPTS) $(BUILDDIR)/changes
209189
@echo
210190
@echo "The overview file is in $(BUILDDIR)/changes."
211191

212192
.PHONY: linkcheck
213193
linkcheck:
214-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
215194
$(SPHINXBUILD) -b linkcheck $(ALLSPHINXOPTS) $(BUILDDIR)/linkcheck
216195
@echo
217196
@echo "Link check complete; look for any errors in the above output " \
218197
"or in $(BUILDDIR)/linkcheck/output.txt."
219198

220199
.PHONY: doctest
221200
doctest:
222-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
223201
$(SPHINXBUILD) -b doctest $(ALLSPHINXOPTS) $(BUILDDIR)/doctest
224202
@echo "Testing of doctests in the sources finished, look at the " \
225203
"results in $(BUILDDIR)/doctest/output.txt."
226204

227205
.PHONY: coverage
228206
coverage:
229-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
230207
$(SPHINXBUILD) -b coverage $(ALLSPHINXOPTS) $(BUILDDIR)/coverage
231208
@echo "Testing of coverage in the sources finished, look at the " \
232209
"results in $(BUILDDIR)/coverage/python.txt."
233210

234211
.PHONY: xml
235212
xml:
236-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
237213
$(SPHINXBUILD) -b xml $(ALLSPHINXOPTS) $(BUILDDIR)/xml
238214
@echo
239215
@echo "Build finished. The XML files are in $(BUILDDIR)/xml."
240216

241217
.PHONY: pseudoxml
242218
pseudoxml:
243-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
244219
$(SPHINXBUILD) -b pseudoxml $(ALLSPHINXOPTS) $(BUILDDIR)/pseudoxml
245220
@echo
246221
@echo "Build finished. The pseudo-XML files are in $(BUILDDIR)/pseudoxml."
247222

248223
.PHONY: dummy
249224
dummy:
250-
$(SPHINXAPIDOC) -o $(BUILDDIR)/generated $(RAIDENMODULEPATH)
251225
$(SPHINXBUILD) -b dummy $(ALLSPHINXOPTS) $(BUILDDIR)/dummy
252226
@echo
253227
@echo "Build finished. Dummy builder generates no files."

docs/adr/0002-testing-strategy.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Better testing framework for the entire Raiden suite (client, MS and PFS)
2-
*********************************************************************
2+
*************************************************************************
33

44
* **Status**: proposed
55
* **Deciders**: @czepluch, @stefante
@@ -12,9 +12,9 @@ Context and Problem Statement
1212
@rakanalh @karlb @LefterisJP and @czepluch had a meeting to discuss testing moving forward. More precisely how we can test the client together with the MS and PFS. Most of the discussion was focused on whether it makes sense to continue to support the scenario player and update it to support the third party services. Currently the SP is good for testing happy cases, but it is not easy to debug when errors occur and it doesn't allow for introspection in the same way as pytest does. On the other hand, the current way that the integration tests work by spinning up a new blockchain per test is very inefficient. It's also quite intimidating for people new to the project or less experienced to grasp how the integration tests work.
1313
Based on these short comings of the current two solutions, we discussed what could be done to create a setup that solves both problems.
1414

15-
.. Decision drivers is optional
15+
1616
Decision Drivers
17-
-------------------
17+
----------------
1818

1919
* Lack debug options for scenario player
2020
* Slow to spin up a fresh blockchain for every integration test
@@ -23,17 +23,17 @@ Decision Drivers
2323
* Have a way of testing all Raiden components
2424

2525
Considered Options
26-
---------------------
26+
------------------
2727

2828
* **Option1:** New repo that integrate the client with the MS/PFS with rewritten fixtures that only spins up one blockchain per test suit session. `Link to meeting discussing this <https://github.com/raiden-network/team/issues/357>`_
2929
* **Option2:** Stick with things as they are and focus on adding functionality to the scenario player
3030

3131
Decision Outcome
32-
-------------------
32+
-----------------
3333

3434
**TBD**
3535

36-
.. Pros and cons are optional
36+
3737
Pros and Cons of the Options
3838
----------------------------
3939

docs/adr/0005-withdraw-expiry.rst

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -67,20 +67,20 @@ Complex:
6767
`total_withdraw=10`.
6868
- Alice requests a withdraw of another 10 tokens. `total_withdraw=20`.
6969
- Alice requests a withdraw of another 20 tokens. `total_withdraw=40`.
70-
- Alice withdraw states look as follows
71-
```
72-
[
73-
{
74-
"total_withdraw": 10,
75-
},
76-
{
77-
"total_withdraw": 20,
78-
}
79-
{
80-
"total_withdraw": 30,
81-
}
82-
]
83-
```
70+
- Alice withdraw states look as follows::
71+
72+
[
73+
{
74+
"total_withdraw": 10,
75+
},
76+
{
77+
"total_withdraw": 20,
78+
}
79+
{
80+
"total_withdraw": 30,
81+
}
82+
]
83+
8484
- Bob does not confirm any withdraw.
8585
- Alice sends Bob a `WithdrawExpired` message for the first withdraw request which had a `total_withdraw=10`.
8686
Before sending `WithdrawExpired`, Alice clears the expired withdraw state `total_withdraw=10`. However, that doesn't affect Alice's `total_withdraw`

docs/adr/template.rst

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Context and Problem Statement
1313
[Describe the context and problem statement, e.g., in free form using two to three sentences. You may want to articulate the problem in form of a question.]
1414

1515
.. Optional
16+
1617
Decision Drivers
1718
----------------
1819

@@ -34,19 +35,19 @@ Decision Outcome
3435
Chosen option: "[option 1]", because [justification. e.g., only option, which meets k.o. criterion decision driver | which resolves force force | … | comes out best (see below)].
3536

3637
Positive Consequences <!-- optional -->
37-
~~~~~~~~~~~~~~~~~~~~~
38+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3839

3940
* [e.g., improvement of quality attribute satisfaction, follow-up decisions required, …]
4041
* …
4142

4243
Negative Consequences <!-- optional -->
43-
~~~~~~~~~~~~~~~~~~~~~~~~~
44+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4445

4546
* [e.g., compromising quality attribute, follow-up decisions required, …]
4647
* …
4748

4849
Pros and Cons of the Options <!-- optional -->
49-
-------------------------------
50+
-------------------------------~~~~~~~~~~~~~~~
5051

5152
[option 1]
5253
~~~~~~~~~~
@@ -79,7 +80,7 @@ Pros and Cons of the Options <!-- optional -->
7980
* … <!-- numbers of pros and cons can vary -->
8081

8182
Links <!-- optional -->
82-
----------------------
83+
-----------------------
8384

8485
* [Link type] [Link to ADR] <!-- example: Refined by `ADR-0005 <0005-example.md>`_ -->
8586
* … <!-- numbers of links can vary -->

docs/index.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ Contents
8282

8383
config_file
8484
trademarks
85-
Raiden Codebase Documentation <./_build/generated/modules>
8685

8786
.. toctree::
8887
:maxdepth: 1

0 commit comments

Comments
 (0)