You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@rakanalh @karlb @LefterisJP and @czepluch had a meeting to discuss testing moving forward. More precisely how we can test the client together with the MS and PFS. Most of the discussion was focused on whether it makes sense to continue to support the scenario player and update it to support the third party services. Currently the SP is good for testing happy cases, but it is not easy to debug when errors occur and it doesn't allow for introspection in the same way as pytest does. On the other hand, the current way that the integration tests work by spinning up a new blockchain per test is very inefficient. It's also quite intimidating for people new to the project or less experienced to grasp how the integration tests work.
13
13
Based on these short comings of the current two solutions, we discussed what could be done to create a setup that solves both problems.
14
14
15
-
.. Decision drivers is optional
15
+
16
16
Decision Drivers
17
-
-------------------
17
+
----------------
18
18
19
19
* Lack debug options for scenario player
20
20
* Slow to spin up a fresh blockchain for every integration test
@@ -23,17 +23,17 @@ Decision Drivers
23
23
* Have a way of testing all Raiden components
24
24
25
25
Considered Options
26
-
---------------------
26
+
------------------
27
27
28
28
* **Option1:** New repo that integrate the client with the MS/PFS with rewritten fixtures that only spins up one blockchain per test suit session. `Link to meeting discussing this <https://github.com/raiden-network/team/issues/357>`_
29
29
* **Option2:** Stick with things as they are and focus on adding functionality to the scenario player
Copy file name to clipboardExpand all lines: docs/adr/template.rst
+5-4Lines changed: 5 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -13,6 +13,7 @@ Context and Problem Statement
13
13
[Describe the context and problem statement, e.g., in free form using two to three sentences. You may want to articulate the problem in form of a question.]
14
14
15
15
.. Optional
16
+
16
17
Decision Drivers
17
18
----------------
18
19
@@ -34,19 +35,19 @@ Decision Outcome
34
35
Chosen option: "[option 1]", because [justification. e.g., only option, which meets k.o. criterion decision driver | which resolves force force | … | comes out best (see below)].
0 commit comments