Improve display protocol detection#211
Merged
eylles merged 5 commits intoeylles:masterfrom Jan 26, 2026
Merged
Conversation
Contributor
Author
|
I tested in a virtual machine running x11, i didn't test with wayland yet |
Contributor
Author
|
Closed because it makes more sense to set the environment variables as described by eylles here |
Owner
|
hmm i kinda like the ideas here tho, maybe as a fallback if XDG_SESSION_TYPE is either unset or set to something other than either of x11 or wayland, then fallaback to the detect display_protocol function to try and check if the session type is either x11 or wayland. |
Re-Enable the XDG_SESSION_TYPE check as the primary way to detect if the session is x11 or wayland. If the XDG_SESSION_TYPE is not available try to detect the display protocol as a fallback.
Yeh i unfortunately do care about the formatting this much.
Also re-structure the information to be (hopefully) easier to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #210
x11 and wayland detection works even independently of how the session was started.