Conversation
Closed
AnthonyMichaelTDM
added a commit
to AnthonyMichaelTDM/pywal16
that referenced
this pull request
Oct 1, 2025
…scent parser fixes eylles#13 should unblock eylles#158
AnthonyMichaelTDM
added a commit
to AnthonyMichaelTDM/pywal16
that referenced
this pull request
Oct 1, 2025
…scent parser fixes eylles#13 should unblock eylles#158
Contributor
|
Since #187 was merged a few months ago, this should be unblocked. Unless I'm missing something you should be able to just rebase this ontop of the current master and be good to go |
Owner
Author
|
yeh, there are other changes i want to do to this PR, will try to commit them today and merge |
The dumb github web editor screwed this up
Owner
Author
|
nevermind, changed ideas the further changes i wanted to make here will go to a different branch |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to change colors with the pywalfox algorithm.
blocking:
unfortunately this is a time when once again i'm hitting face first into the wall that is #13
which means that it would only be possible to add colors modified like this as part of the special colors in the main color dict, not allow users to call the foxify property from a template as the way template export function is defined at:
pywal16/pywal/export.py
Lines 24 to 83 in ec2ad5a
as a finditer and such careless reggular expression usage should have never been part of the function... but we are already past beyond that point...
anyway will have to leave this open until that problem is eventually fixed.