feat: bnode relabelling param #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phochste
previously requested changes
May 27, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
jeswr
commented
May 27, 2024
__test_utils__/util.ts
Outdated
Comment on lines
281
to
288
|
|
||
| it('should execute the n3reasoner on surface query', async () => { | ||
| await expect(n3reasoner(surfaceQueryQuads)).rejects.toThrow(/inference_fuse/); | ||
| }); | ||
|
|
||
| it('should execute the n3reasoner on surface query [bnodeRelabeling: false]', async () => { | ||
| await expect(n3reasoner(surfaceQueryQuads, undefined, { bnodeRelabeling: false })).rejects.toThrow(/inference_fuse/); | ||
| }); |
There was a problem hiding this comment.
|
The inference fuse can be tested with : With |
jeswr
commented
May 27, 2024
__test_utils__/util.ts
Outdated
Comment on lines
305
to
306
| // see https://github.com/rdfjs/N3.js/issues/332 | ||
| .map(quad => mapTerms(quad, term => term.termType === 'BlankNode' ? DataFactory.blankNode(term.value.replace(/\./g, '__dot__')) : term)) |
There was a problem hiding this comment.
We should get rid of this once rdfjs/N3.js#332 is resolved.
|
🎉 This PR is included in version 16.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.