my suggested changes to the profile

[AmyMoriyama]

Never done a pull request before, so, this could be wrong somehow, but this is my attempt at suggesting changes to the profile. Feel free to flip a table or edit or whatever lol

[eyedeekay]

Thanks very much for the PR! Ack on most of the changes, but please move your changes to user.js from user.js to user-overrides.js if they don't appear in Arkenfox's default user.js, the reason being that the "base" user.js is a by-product of the build process, i.e. it is generated automatically, and the user-overrides.js is used to apply additional changes on top of the base. So if your changes go into user.js then they'll be over-written the next time I generate the base profile. Everything else makes sense to me in the profile sections.

I would like to know what changes you made in the sqlite file in some detail though. IIRC we only use that file for configuring a default search engine and would like to know what you're using it for before I go loading it into a profile.

Oh I see that's a new sqlite file, and it's places.sqlite... I'm not sure I like that. Default bookmarks I take it? If so we should load them from somewhere else, I'm honestly not sure whether I'd rather include a places.sqlite file or just control it from a browser extension.

[AmyMoriyama]

Ideally, I would like to not have the sqlite file, but that is a little beyond my knowledge right now. I'll look into the overrides and see what I can to to clean this up a little. Any suggestions for the best way to add bookmarks outside of including the sqlite?

[eyedeekay]

When you have a hammer everything looks like a nail sometimes. My tool of choice would probably be to add it within a WebExtension, it would be small, understandable when distrubuted in plain-text, signed by Mozilla when distributed in binary, and if it's just adding bookmarks it's easy to guarantee it does not contain fingerprintable resources. It could have a separate WebExtension just for adding bookmarks, or I could add them to I2P in Private Browsing which provides the Firefox UI integrations in this configuration. It would also be possible to use the WebExtensions update mechanism as a way of updating the bookmarks without doing a point-release of the profile manager. Could be some neat benefits, but it's also a little more work and I've not considered other options very well yet. IIRC, there was a file called bookmarks.html which we used to use but it could only add the bookmarks on the first run. That option may be worth researching also.

[eyedeekay]

policies.json is an interesting prospect but it would only work for the "Portable" case, and not for appimages AFAIK: https://github.com/mozilla/policy-templates/blob/master/README.md

[eyedeekay]

@AmyMoriyama I made something to help in case the WebExtension approach is what we land on, here's what I'm talking about: https://github.com/eyedeekay/Tassel https://eyedeekay.github.io/Tassel

[eyedeekay]

https://github.com/eyedeekay/I2P-Bookmarks If you want to provide me with a plaintext list of the bookmarks I'll add them here then incorporate the extension into the profile