feat: Try to grab the date from the URL before going to the secondary… #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andremacola yes, please review these packages to enhance your pull request. Both offer a wider range of selectors for extracting date information from HTML (here and here). To address the inconsistent output issue, I recommend implementing more rigorous validation. For example, if a date cannot be detected, ensure the result is an empty string rather than undefined |
|
I'm canceling this PR and organizing my fork. Soon I'll send more complete changes regarding the date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small update to try to capture and validate the date from the URL before passing it to the secondary elements (which can be complicated depending on internationalization).
I’m looking at the examples from the other libraries you mentioned to see how we can further improve.