Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo captains #6234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update repo captains #6234

wants to merge 1 commit into from

Conversation

UlisesGascon
Copy link
Member

I just added myself to the packages that I plan to put a lot of energy going on 🥳

cc: @expressjs/express-tc

@UlisesGascon UlisesGascon self-assigned this Dec 20, 2024
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in itself but wasn't the purpose of the repo captain to only have one per repository? for some package it seems that half the TC is a captain, hence we don't really have one captain :D

what do you think @expressjs/express-tc

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleytodd
Copy link
Member

wasn't the purpose of the repo captain to only have one per repository?

I didn't intend that when I proposed it, in fact I intended the opposite. Re reading this section though I wonder if we need to clarify:

Any TC member or existing captain on the repo can nominate another committer to the captain role, submit a PR to this doc, in the Active Project Captains section (maintaining the sort order) with the project, their GitHub handle and npm username (if different).

My original intent when @gireeshpunathil and I worked on this was that we would have a few captains on each repo (for redundancy and sustainability). I could see two changes to this wording that would help clarify:

  1. "Repos can have as many captians as makes sense for the scope of work"
  2. "an TC member or repos captian on the same project can nominate" (to clarify that a repo captian from another project should not nominate a captian for a differnt project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants