Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method functions with no path should error #5957

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Method functions with no path should error #5957

merged 1 commit into from
Jan 16, 2025

Conversation

wesleytodd
Copy link
Member

@NewEraCracker
Copy link

NewEraCracker commented Oct 8, 2024

This depends on #5956 which should be merged first.

Thank you.

PS: Ping @wesleytodd Please approve the other pull request if that's okay.

@wesleytodd wesleytodd force-pushed the no-path-test branch 3 times, most recently from ff86319 to 42e2bca Compare January 15, 2025 23:19
@wesleytodd
Copy link
Member Author

Very annoyed that my cherry-pick pulled in these changes. I am on a new laptop and am using nvim now and this is the first time I did a merge conflict edit with it....IT AUTO FORMATTED THE FILE ON SAVE. lol. Fixing this now.

@wesleytodd
Copy link
Member Author

wesleytodd commented Jan 15, 2025

Apparent the neovim typescript tools will auto-format js on save. I didn't add configuration for that plugin so I guess it is by default. Disabled that and now this should be good.

@wesleytodd wesleytodd merged commit 52d9781 into 4.x Jan 16, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants