Skip to content

fix: Type idField in EntityConfiguration as TIDField#425

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield
Feb 12, 2026
Merged

fix: Type idField in EntityConfiguration as TIDField#425
wschurman merged 1 commit intomainfrom
wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 6, 2026

Why

Noticed this was mis-typed in a later PR, hoisted into this one.

How

Update type of EntityConfiguration.idField to be TIDField, which is the most correct and precise type for the field. This will help later on when adding pagination ID field stuff.

The other changes to tests are fixes since these previously were underspecified and changing the field type exposed these missing types. (claude informed me of this)

Test Plan

yarn tsc

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a9d09f4) to head (f314db7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #425    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          108       108            
  Lines        14869     14872     +3     
  Branches      1288       759   -529     
==========================================
+ Hits         14869     14872     +3     
Flag Coverage Δ
integration 22.40% <0.00%> (-0.01%) ⬇️
unittest 96.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman force-pushed the wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield branch from 6164b63 to fbce886 Compare February 9, 2026 23:28
@wschurman wschurman force-pushed the wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method branch 2 times, most recently from c475a0e to 9de79ed Compare February 9, 2026 23:31
@wschurman wschurman force-pushed the wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield branch from fbce886 to 29a3d8c Compare February 9, 2026 23:31
@wschurman wschurman force-pushed the wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method branch 2 times, most recently from bacc551 to 8bc9c11 Compare February 10, 2026 00:02
@wschurman wschurman force-pushed the wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield branch from 29a3d8c to 0c6daeb Compare February 10, 2026 00:02
@wschurman wschurman marked this pull request as ready for review February 10, 2026 00:12
@wschurman wschurman requested a review from quinlanj February 10, 2026 00:12
@wschurman wschurman force-pushed the wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method branch from 8bc9c11 to 2b671cb Compare February 10, 2026 03:01
@wschurman wschurman force-pushed the wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield branch from 0c6daeb to 4dacb13 Compare February 10, 2026 03:01
Copy link
Member Author

wschurman commented Feb 12, 2026

Merge activity

  • Feb 12, 1:26 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 12, 1:27 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 12, 1:30 AM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method to graphite-base/425 February 12, 2026 01:26
@wschurman wschurman changed the base branch from graphite-base/425 to main February 12, 2026 01:26
@wschurman wschurman force-pushed the wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield branch from 4dacb13 to f314db7 Compare February 12, 2026 01:27
@wschurman wschurman merged commit be40bcf into main Feb 12, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-06-fix_type_idfield_in_entityconfiguration_as_tidfield branch February 12, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments