Conversation
This was referenced Feb 6, 2026
Merged
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 108 108
Lines 14869 14872 +3
Branches 1288 759 -529
==========================================
+ Hits 14869 14872 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6164b63 to
fbce886
Compare
c475a0e to
9de79ed
Compare
fbce886 to
29a3d8c
Compare
bacc551 to
8bc9c11
Compare
29a3d8c to
0c6daeb
Compare
8bc9c11 to
2b671cb
Compare
0c6daeb to
4dacb13
Compare
This was referenced Feb 10, 2026
quinlanj
approved these changes
Feb 12, 2026
Member
Author
Merge activity
|
4dacb13 to
f314db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Noticed this was mis-typed in a later PR, hoisted into this one.
How
Update type of EntityConfiguration.idField to be
TIDField, which is the most correct and precise type for the field. This will help later on when adding pagination ID field stuff.The other changes to tests are fixes since these previously were underspecified and changing the field type exposed these missing types. (claude informed me of this)
Test Plan
yarn tsc