Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload fileName with EnvVar create/update commands #2646

Conversation

khamilowicz
Copy link
Contributor

Why

ENG-13652: Show filename when value is a file

eas env:create and eas:env:update should upload fileName, just like website.

How

  • Added fileName parameter

Test Plan

Tested manually

Copy link

linear bot commented Oct 22, 2024

Copy link

Size Change: -300 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -300 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (214cff0) to head (b6d7a3b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/create.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/env/update.ts 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
- Coverage   53.05%   53.05%   -0.00%     
==========================================
  Files         566      566              
  Lines       21615    21617       +2     
  Branches     4236     4236              
==========================================
  Hits        11466    11466              
- Misses      10119    10121       +2     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Oct 22, 2024 — with Graphite App
@khamilowicz khamilowicz marked this pull request as ready for review October 22, 2024 15:26
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@khamilowicz khamilowicz merged commit 3a7dfb0 into main Oct 22, 2024
11 of 12 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-13653-show-file-name-when-editing-variables branch October 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants