Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add exit option to eas credentials interactive menu #2570

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Sep 16, 2024

Why

https://exponent-internal.slack.com/archives/C017N0N99RA/p1726226230206999

Right now the only way to exit the eas credentials command is to kill the process by doing ctrl+c. Let's add an exit option to the interactive menu.

How

Add exit option to menu.

Test Plan

Test manually

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szdziedzic and the rest of your teammates on Graphite Graphite

@szdziedzic szdziedzic marked this pull request as ready for review September 16, 2024 11:24
Copy link

github-actions bot commented Sep 16, 2024

Size Change: -842 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -842 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.89%. Comparing base (69014fe) to head (3f2f88e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/eas-cli/src/credentials/manager/ManageAndroid.ts 0.00% 1 Missing and 1 partial ⚠️
...kages/eas-cli/src/credentials/manager/ManageIos.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
- Coverage   51.89%   51.89%   -0.00%     
==========================================
  Files         563      563              
  Lines       21260    21266       +6     
  Branches     4341     4343       +2     
==========================================
+ Hits        11031    11033       +2     
- Misses       9341     9345       +4     
  Partials      888      888              
Flag Coverage Δ
51.89% <33.34%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the 09-16-_eas-cli_add_exit_option_to_eas_credentials_interactive_menu branch from dbf6f51 to 3f2f88e Compare September 26, 2024 14:48
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 7edc10f into main Sep 27, 2024
10 checks passed
@szdziedzic szdziedzic deleted the 09-16-_eas-cli_add_exit_option_to_eas_credentials_interactive_menu branch September 27, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants