Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eas-cli): check if export is available before validating project #2569

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

byCedric
Copy link
Member

Why

I parallized these two actions to make the command as fast as possible. Unfortunately, this has the side effect of conflating a prompt with a command error (as seen in the screenshot below).

image

This reverts the parallized action back into two stages, where they can't be mixed up.

How

  • First validate if a (valid) export is available
  • Then validate if the project is set up properly

Test Plan

  • $ bun create expo ./test
  • $ cd ./test
  • $ eas deploy
    • Should not trigger the prompt in the screenshot, only the error

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: +439 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +439 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.12%. Comparing base (dadf58f) to head (2a3e88d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/deploy.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2569      +/-   ##
==========================================
- Coverage   52.13%   52.12%   -0.00%     
==========================================
  Files         559      559              
  Lines       21110    21111       +1     
  Branches     4317     4317              
==========================================
  Hits        11003    11003              
- Misses       9229     9230       +1     
  Partials      878      878              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 41fd76c into main Sep 16, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/deploy-abort-when-export-isnt-found branch September 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants