Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): remove the cursor space when prompting dev domain after input #2568

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

byCedric
Copy link
Member

Why

This drops the extra space between <input> .staging.expo.app after choosing a project URL.

How

  • Dropped cursor space after selecting project URL

Test Plan

image

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: -187 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -187 B (0%)

compressed-size-action

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.10%. Comparing base (d7dfef0) to head (60ffe75).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/deployment.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
- Coverage   52.10%   52.10%   -0.00%     
==========================================
  Files         559      559              
  Lines       21097    21099       +2     
  Branches     4315     4316       +1     
==========================================
  Hits        10991    10991              
- Misses       9228     9230       +2     
  Partials      878      878              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 9c4ff98 into main Sep 14, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/eas-cli/deploy-project-url-prompt branch September 14, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants