[eas-cli] [ENG-10146] Allow submission of builds in progress #2543

radoslawkrzemien · 2024-09-10T14:01:18Z

Why

https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

How

When using --latest or selecting a build from a list when prompted, now the builds in-progress, in-queue and new are returned as well. All results are then sorted in decreasing order by createdAt and up to limit (4) are returned to the user to pick from

Test Plan

Added tests for the function listing the builds

Manual tests

Creating a build

In-progress build is returned when listing available builds. The description now includes the `status` as well, to differentiate between the builds in-progress and finished

The finished builds are also returned

Selecting in-progress build creates the submission

Created submission on the website

Added tests for allowing to select in progress builds See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

When prompting the user with a list of builds the in-progress builds are now returned first See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

When prompting the user with a list of builds the build status is now displayed let the user know which are finished and which are still in progress See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

linear · 2024-09-10T14:01:21Z

ENG-10146 FR: Add option to trigger auto-submit while waiting for build to complete

radoslawkrzemien · 2024-09-10T14:02:09Z

/changelog-entry new-feature Allow submitting builds in progress

github-actions · 2024-09-10T14:04:46Z

Size Change: +577 B (0%)

Total Size: 52.9 MB

Filename	Size	Change
`./packages/eas-cli/dist/eas-linux-x64.tar.gz`	52.9 MB	+577 B (0%)

_{compressed-size-action}

Adjusted formatting See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

szdziedzic

One general question:

When a submission is created during a build command with --auto-submit it enters special waiting mode on our backend and is only put in the queue when we receive an update from Turtle in WWW that the build is finished or canceled when it fails. Will it behave here the same way? Or is it put in the queue straight away?

lint --fix See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

radoslawkrzemien · 2024-09-10T14:36:14Z

@szdziedzic As far as I can tell it behaves exactly the same way - waiting for the build to finish first

radoslawkrzemien · 2024-09-10T14:38:32Z

/changelog-entry new-feature Allow submitting builds in progress

codecov · 2024-09-10T14:38:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.13%. Comparing base (a7f939f) to head (45b91ac).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2543      +/-   ##
==========================================
+ Coverage   52.09%   52.13%   +0.04%     
==========================================
  Files         559      559              
  Lines       21102    21110       +8     
  Branches     4316     4317       +1     
==========================================
+ Hits        10992    11003      +11     
+ Misses       9232     9229       -3     
  Partials      878      878

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added the changelog entry since the bot does not seem to be working See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

szdziedzic

good job, it generally looks good 🚀, although I think we should also allow to submit new and in-queue builds as well

szdziedzic · 2024-09-12T09:32:13Z

packages/eas-cli/src/submit/utils/builds.ts

 appId,
 limit,
 offset: 0,
 filter: {
 platform,
 distribution: DistributionType.Store,
- status: BuildStatus.Finished,
+ status: BuildStatus.InProgress,


What about NEW and IN_QUEUE builds? I believe we should handle submitting these as well.

I don't see why not, I'll add them

packages/eas-cli/src/submit/utils/builds.ts

Query returning the potential builds for submission now also returns build in `new` and `in-queue` statuses. All builds are then sorted decreasingly by `createdAt` and up to `limit` are returned See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

…-10146_allow_submission_of_builds_in_progress # Conflicts: # CHANGELOG.md

yarn lint --fix See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

sjchmiela · 2024-09-12T14:55:50Z

packages/eas-cli/src/submit/ArchiveSource.ts

@@ -368,6 +369,7 @@ function formatBuildChoice(build: BuildFragment): prompts.Choice {
 ? chalk.bold(message.length > 200 ? `${message.slice(0, 200)}...` : message)
 : null,
 },
+ { name: 'Status', value: status.replace('_', ' ').toLowerCase() },


nit: i'd rather have a mapping Record<status, description>

Created build status mapping instead string modification See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

…-10146_allow_submission_of_builds_in_progress # Conflicts: # CHANGELOG.md

radoslawkrzemien · 2024-09-13T14:36:47Z

@szdziedzic any further feedback?

…-10146_allow_submission_of_builds_in_progress # Conflicts: # CHANGELOG.md

github-actions · 2024-09-16T09:30:28Z

✅ Thank you for adding the changelog entry!

radoslawkrzemien added 3 commits September 10, 2024 15:50

[eas-cli] Add tests

699f138

Added tests for allowing to select in progress builds See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

[eas-cli] Allow in progress builds

913bb2f

When prompting the user with a list of builds the in-progress builds are now returned first See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

[eas-cli] Adjust description

ae0edda

When prompting the user with a list of builds the build status is now displayed let the user know which are finished and which are still in progress See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

radoslawkrzemien requested review from szdziedzic, khamilowicz and sjchmiela as code owners September 10, 2024 14:01

radoslawkrzemien added 2 commits September 10, 2024 16:07

[eas-cli] Reformat

ffd35b9

Adjusted formatting See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

[eas-cli] Reformat

99e8dc3

Adjusted formatting See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

szdziedzic reviewed Sep 10, 2024

View reviewed changes

[eas-cli] Lint fix

cec4a1d

lint --fix See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

[eas-cli] Add changelog

41ccaf7

Added the changelog entry since the bot does not seem to be working See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

radoslawkrzemien requested a review from szdziedzic September 11, 2024 09:13

szdziedzic requested changes Sep 12, 2024

View reviewed changes

radoslawkrzemien added 2 commits September 12, 2024 15:45

Merge remote-tracking branch 'origin/main' into @radoslawkrzemien/ENG…

5faff60

…-10146_allow_submission_of_builds_in_progress # Conflicts: # CHANGELOG.md

radoslawkrzemien requested a review from szdziedzic September 12, 2024 13:47

[eas-cli] Lint

f965739

yarn lint --fix See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

sjchmiela approved these changes Sep 12, 2024

View reviewed changes

radoslawkrzemien added 2 commits September 13, 2024 16:24

[eas-cli] Add mapping

7f546c7

Created build status mapping instead string modification See: https://linear.app/expo/issue/ENG-10146/fr-add-option-to-trigger-auto-submit-while-waiting-for-build-to

Merge remote-tracking branch 'origin/main' into @radoslawkrzemien/ENG…

ace04b7

…-10146_allow_submission_of_builds_in_progress # Conflicts: # CHANGELOG.md

szdziedzic approved these changes Sep 16, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into @radoslawkrzemien/ENG…

45b91ac

…-10146_allow_submission_of_builds_in_progress # Conflicts: # CHANGELOG.md

radoslawkrzemien merged commit dadf58f into main Sep 16, 2024
9 checks passed

radoslawkrzemien deleted the @radoslawkrzemien/ENG-10146_allow_submission_of_builds_in_progress branch September 16, 2024 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[eas-cli] [ENG-10146] Allow submission of builds in progress #2543

[eas-cli] [ENG-10146] Allow submission of builds in progress #2543

radoslawkrzemien commented Sep 10, 2024 •

edited

Loading

linear bot commented Sep 10, 2024

radoslawkrzemien commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 •

edited

Loading

szdziedzic left a comment

radoslawkrzemien commented Sep 10, 2024

radoslawkrzemien commented Sep 10, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

szdziedzic left a comment

szdziedzic Sep 12, 2024

radoslawkrzemien Sep 12, 2024

sjchmiela Sep 12, 2024

radoslawkrzemien commented Sep 13, 2024

github-actions bot commented Sep 16, 2024

[eas-cli] [ENG-10146] Allow submission of builds in progress #2543

[eas-cli] [ENG-10146] Allow submission of builds in progress #2543

Conversation

radoslawkrzemien commented Sep 10, 2024 • edited Loading

Why

How

Test Plan

Manual tests

Creating a build

In-progress build is returned when listing available builds. The description now includes the status as well, to differentiate between the builds in-progress and finished

The finished builds are also returned

Selecting in-progress build creates the submission

Created submission on the website

linear bot commented Sep 10, 2024

radoslawkrzemien commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 • edited Loading

szdziedzic left a comment

Choose a reason for hiding this comment

radoslawkrzemien commented Sep 10, 2024

radoslawkrzemien commented Sep 10, 2024

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

szdziedzic left a comment

Choose a reason for hiding this comment

szdziedzic Sep 12, 2024

Choose a reason for hiding this comment

radoslawkrzemien Sep 12, 2024

Choose a reason for hiding this comment

sjchmiela Sep 12, 2024

Choose a reason for hiding this comment

radoslawkrzemien commented Sep 13, 2024

github-actions bot commented Sep 16, 2024

radoslawkrzemien commented Sep 10, 2024 •

edited

Loading

In-progress build is returned when listing available builds. The description now includes the `status` as well, to differentiate between the builds in-progress and finished

github-actions bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading