Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warning and tests for python 3.12 #61

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Update warning and tests for python 3.12 #61

merged 4 commits into from
Sep 14, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Update warning and tests for python 3.12.

The condition in #58 was incorrect, but wasn't tested correctly because python 3.12 hadn't been added to the CI.

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the test suite, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added tests Test suite or CI related bug Something isn't working labels Sep 13, 2023
@adrianeboyd adrianeboyd merged commit 7225fc9 into explosion:main Sep 14, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmitsch rmitsch rmitsch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working tests Test suite or CI related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianeboyd @rmitsch