-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new OS models: Zephyr and Yi #392
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # spacy_llm/tasks/builtin_task.py
…done by spaCy's slicing directly.
…for handling both types of tasks. Update tests.
# Conflicts: # spacy_llm/tests/tasks/test_rel.py
return Doc.from_docs(list(shards), ensure_whitespace=True) | ||
with warnings.catch_warnings(): | ||
warnings.filterwarnings( | ||
"ignore", | ||
category=UserWarning, | ||
message=".*Skipping .* while merging docs.", | ||
) | ||
return Doc.from_docs(list(shards), ensure_whitespace=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where this edit is coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a drive-by because I noticed the warnings filter is missing here 🙃 I can move this into a separate PR, if you mind having it in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all just a bit confusing with the huge (mostly unrelated) git history etc - I do in general appreciate more "atomic" PRs ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do in general appreciate more "atomic" PRs ;-)
I know 🫣
It's all just a bit confusing with the huge (mostly unrelated) git history etc
Yeah, I don't know why that's the case. The branches should all be updated.
Looks like the GPU tests failed... |
I couldn't figure out why exactly the CI runner fails with |
Let's finish #428 first, then resolve the conflicts and finalize this one. |
This was unintentionally closed when I reset the |
Description
Add support for OS/HF models:
Corresponding documentation PR
explosion/spaCy#13174
Types of change
New feature.
Checklist
tests
andusage_examples/tests
, and all new and existing tests passed. This includespytest
ran with--external
)pytest
ran with--gpu
)