Jan 1 bug fixes #90
Merged
Jan 1 bug fixes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the logic for determining past months in the ForecastTable component by introducing a new `isMonthInPast` function, improving clarity and maintainability. - Replaced direct comparisons with the current month and year to utilize the new function, ensuring accurate calculations for actual values and totals. - Enhanced the readability of the code by consolidating date-related logic, making future modifications easier. These changes improve the accuracy of the financial forecasting calculations and enhance the overall code structure.
- Added `workingDays` and `realizedWorkingDays` fields to the YearlyForecast GraphQL schema, improving the data model for financial forecasting. - Updated the `resolve_yearly_forecast` function to calculate total working days and realized working days based on the current date, enhancing the accuracy of the forecast. - Modified the frontend to display working days metrics in the Yearly Forecast 2025 component, providing users with better insights into their financial goals. These changes improve the financial forecasting capabilities and enhance user visibility into working day metrics.
- Updated the forecast calculation logic in `forecast.py` to prevent division by zero by introducing a safe divisor for projected values, improving accuracy in financial forecasts. - Enhanced the `ConsultantSummary` class in `revenue_tracking.py` to safely check for the presence of `by_worker` in project data, ensuring robust data handling and preventing potential errors. - Consolidated consultant name collection logic to improve readability and maintainability. These changes enhance the reliability of forecast calculations and improve the overall data integrity in consultant summaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.