Code improvements dec 2024 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new models for Everhour including User, Billing, Rate, Budget, Project, Client, Appointment, and Task, enhancing data structure and validation using Pydantic. - Implemented the Everhour client class to handle API interactions, including methods for fetching users, appointments, projects, and tasks. - Updated the `__init__.py` files to include new models and client in the module exports, ensuring proper accessibility. - These changes lay the groundwork for integrating Everhour's functionalities into the application, improving project and task management capabilities.
- Removed the old models.py file and replaced it with individual model files for User, Billing, Rate, Budget, Project, Client, Appointment, and Task, improving modularity and maintainability. - Introduced a new __init__.py file to facilitate the import of these models, ensuring a cleaner and more organized module structure. - Each model now adheres to Pydantic's validation, enhancing data integrity and usability across the application. These changes streamline the Everhour integration, making it easier to manage and extend the data models in the future.
- Updated the Appointment, Client, and Task models to utilize Pydantic's Field and field_validator for improved data validation and aliasing. - Replaced from_json methods with direct model instantiation using unpacking for better clarity and performance. - Enhanced the handling of date fields to ensure proper parsing from string formats. - These changes streamline the model definitions, improve data integrity, and prepare the codebase for future enhancements.
- Introduced a comprehensive set of models for WordPress, including Post, User, CommentStatus, PingStatus, PostStatus, PostType, Acf, Content, and Excerpt, utilizing Pydantic for enhanced data validation and structure. - Implemented the Wordpress client class to facilitate API interactions, including methods for fetching posts, users, media, and post types. - Created __init__.py files to streamline module imports and ensure proper accessibility of the new models and client. - These changes establish a robust foundation for integrating WordPress functionalities into the application, improving data management and API interaction capabilities.
- Updated the EventDetail and Post models to replace the deprecated validator with field_validator for improved data validation and clarity. - Enhanced the handling of author, date, status, acf, and yoast_head_json fields to ensure proper validation and processing. - These changes streamline the model definitions, improve data integrity, and align with the latest Pydantic practices.
- Deleted the ontology.py file, which contained the Ontology model and related classes (Class, Worker, Client, Case, Entry) used for managing WordPress data. - This removal streamlines the codebase by eliminating unused or redundant components, potentially in preparation for a new implementation or refactor. - The change enhances maintainability and reduces complexity in the backend models.
…ec_2024' into code_improvements_dec_2024
- Renamed the Project import in the semantic module to TaskProject for clarity. - Updated the __all__ exports in several modules to include new classes and improve organization. - Deleted the outdated timetracker.py file and replaced it with a new structure for time tracking, including the introduction of TimeTracker, Appointment, Project, and TimeBudget classes. - Enhanced the WorkerPost model with additional attributes to better represent worker roles and statuses. - Streamlined the ontology client module by removing unnecessary imports and ensuring proper model integration. These changes improve the organization and functionality of the semantic models, facilitating better time tracking and worker management.
- Introduced a new Pipedrive client structure, including models for Activity, Deal, Note, Organization, Person, Stage, and User, improving the organization and clarity of the Pipedrive integration. - Removed the outdated pipedrive.py file to streamline the codebase. - Updated the Worker model to correctly reference activities from the post metadata, enhancing the accuracy of account management logic. - Improved the __all__ exports in the Pipedrive module to include newly added models and ensure proper encapsulation. These changes enhance the maintainability and functionality of the Pipedrive integration while improving the Worker model's accuracy in handling activities.
- Introduced a new OmniModels package to enhance organization and encapsulation of semantic models. - Created a structured sales funnel module, including models for Stage, Deal, Activity, and AccountManager, improving clarity and maintainability. - Implemented a SalesFunnelB2B client to manage interactions with Pipedrive, streamlining deal and activity management. - Updated __all__ exports across modules to ensure proper encapsulation and accessibility of newly added classes. These changes improve the overall architecture of the backend models, facilitating better management of sales funnel data and enhancing the integration with Pipedrive.
…king Function - Added logic to handle partial fees when certain conditions are met, improving the accuracy of penalty calculations for sponsors, clients, and account managers. - Ensured that the penalty accumulation logic remains intact while introducing the new partial fee handling, enhancing the overall functionality of revenue tracking. These changes improve the precision of revenue tracking calculations, facilitating better financial management and reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.