-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major backend files structure change. #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `pyrightconfig.json` for type checking configuration. - Created `setup.py` files for `omni-api`, `omni-models`, and `omni-utils` packages. - Added core utility functions in `omni_utils` for decorators, caching, and data manipulation. - Implemented helper functions for formatting, slug generation, and week calculations. - Enhanced logging capabilities with `ElkLogger` for request tracking in the API. - Removed an unused line from `requirements.txt` to clean up dependencies.
- Deleted empty `__init__.py` files from `backend/models/src/base` and `backend/models/src/domain` to clean up the project structure. - Introduced new files in `backend/models/src/omni_models` for `omnidatasets`, `omnimodels`, and various analytics modules, enhancing the organization of the codebase. - Added multiple new datasets and analytics classes to improve data handling and analysis capabilities within the omni-models framework. - Implemented new semantic models and domain classes to support enhanced functionality and data interactions across the application.
- Removed the "playground/src" directory from the Pyright configuration to streamline type checking. - Updated import statements across multiple files to reflect the new structure under "omni_models" and "utils", enhancing code organization and maintainability. - Consolidated imports in various modules, ensuring consistency and clarity in the codebase. - Improved overall project structure by aligning imports with the new directory hierarchy.
- Updated `pyrightconfig.json` to include the new `shared/src` directory for improved type checking. - Added `omni-shared` as a dependency in `setup.py` for both `api` and `models` to facilitate shared functionality. - Refactored import statements across multiple files to utilize the new `omni_shared` module, enhancing code clarity and maintainability. - Introduced new `globals.py` and `settings.py` in the `shared` directory to centralize shared configurations and global variables.
- Updated import paths across multiple files to utilize the new `omni_shared` and `omni_utils` modules, improving code organization and clarity. - Replaced relative imports with absolute paths for better maintainability. - Consolidated imports from `omni_utils.decorators` to streamline decorator usage throughout the codebase. - Enhanced the `load_schema` function in `queries.py` to use a base directory path for schema file references, improving path management.
- Updated base image from Python 3.12 to 3.11 for compatibility. - Changed working directory from /code to /app for better organization. - Consolidated requirements files and installation commands for backend components. - Enhanced the Dockerfile to include environment variables for Flask application. - Streamlined the copy commands to reflect the new directory structure, improving clarity and maintainability.
- Updated import statements across multiple files to align with the new directory structure, improving code clarity and maintainability. - Consolidated imports from various modules to streamline usage and ensure consistency throughout the codebase. - Enhanced type checking configuration in `pyrightconfig.json` to reflect recent changes in project organization. - Removed unused configurations and files to clean up the project structure and improve overall organization.
- Updated COPY commands in the Dockerfile to reflect the new directory structure, improving clarity and maintainability. - Ensured that requirements files are copied from the correct paths, enhancing the build process for the backend.
dopic
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dockerfile looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.