Financial info on account manager page #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.slice(1)` operation was unnecessary as it modified the path segments incorrectly. This change ensures that all path segments are processed properly, maintaining accurate breadcrumb generation.
Introduced the NavUser component for displaying user information and sign-out functionality. Updated OmniSidebar to a dual-sidebar layout for better navigation, allowing section selection on the left and details on the right, along with conditional display based on user permissions.
In the OmniBreadcrumb component, included the Slash icon from lucide-react in the BreadcrumbSeparator for improved visual demarcation. Additionally, modified the condition to correctly display the first segment as a BreadcrumbPage.
The bottom padding was removed from the main container within the layout file. This change aims to ensure consistent spacing, especially when rendering child components.
Replaced repetitive header code with the SectionHeader component for cleaner and more maintainable code. Adjusted margins and padding to standardize layout spacing and improve design consistency.
Replaced manual header divs with the reusable `SectionHeader` component for more consistent styling. Integrated `Avatar` and `Badge` components from Catalyst library, and added padding to improve visual spacing.
Replaced static header elements with the SectionHeader component. Adjusted padding and margins for better spacing and removed redundant Divider component. Encapsulated the sponsor list within a padded container for improved layout consistency.
Replaced manually coded section headers with SectionHeader component for better readability and maintenance. Adjusted layout spacing and container properties to improve alignment and visual consistency. Removed redundant Divider component to streamline the UI.
Replaced manual section headers with SectionHeader component for consistency. Added motion animations to CasesGallery for improved user experience. Minor layout adjustments and SSR support in data query.
Integrated the SectionHeader component across ClientStatsSection, ClientGallery, and the clients page to improve the layout and readability. This change also includes minor refactoring for better alignment and animation effects for client galleries.
Updated the margin and padding to improve the layout and spacing within the Revenue Tracking section. Changed padding of the Summaries component wrapper from "p-4" to "px-2" and adjusted margin and padding properties on various div elements to fine-tune spacing for better visual harmony.
Extracted the CategoryCard component for better readability and reusability. Changed the default value for the selected dataset in ConsultantPage to "timesheet-this-month".
Replaced Card component with a simpler div structure to streamline the TimesheetSummary UI. Improved readability and maintainability by using cleaner conditional rendering and simplified class handling.
Updated card descriptions to be more concise and moved from Card components to div elements for better styling flexibility. Introduced totalHours prop to enhance TimesheetSummary calculations.
Replaced the `Card` component with custom styled `div` elements to provide more control over card styling. Added keyboard accessibility and applied conditional styling for better visual differentiation.
Enhanced the revenue tracking functionality by adding an optional filter based on the account manager's name. This involved modifying the GraphQL schema and relevant backend functions to accept and handle this new parameter, ensuring accurate results for queries requiring specific account manager data.
Updated `account_manager_name` to `account_manager_name_or_slug` in revenue tracking logic. This change ensures the code can handle both account manager names and slugs, improving flexibility and compatibility with varying data inputs.
Adjusted `revenueTracking` schema definition to make `dateOfInterest` optional. Updated resolver to set current date if `dateOfInterest` is not provided, enhancing robustness and default behavior.
Integrated the new revenue tracking summaries component into the account manager page. Adjusted type definitions and GraphQL queries to support the new data structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.