-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving revenue business logic #50
Merged
ElemarJR
merged 11 commits into
eximiaco-labs:main
from
ElemarJR:improving_revenue_business_logic
Nov 27, 2024
Merged
Improving revenue business logic #50
ElemarJR
merged 11 commits into
eximiaco-labs:main
from
ElemarJR:improving_revenue_business_logic
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure contract start/end dates are present and used in revenue tracking calculations for fixed fee projects. This improves the accuracy of fee distribution across months and enhances consistency checks.
Integrated Radix UI Collapsible for better section management in the OmniSidebar component. Updated package.json and yarn.lock to include the new dependency. Adjusted the sidebar structure to use the collapsible component, providing a more interactive and organized interface.
Integrated Radix UI Collapsible for better section management in the OmniSidebar component. Updated package.json and yarn.lock to include the new dependency. Adjusted the sidebar structure to use the collapsible component, providing a more interactive and organized interface.
Refactored the ClientPage to encapsulate allocation-related content within the new AllocationSection component. Additionally, adjusted the styling of the ClientHeader to enhance the visual hierarchy.
Moved the "Cases" section and its associated components from `page.tsx` to `AllocationSection.tsx` for better modularization. This improves code organization by keeping related functionalities together, enhancing maintainability and readability.
Replaced Card component with SectionHeader for a cleaner design. Simplified table rows and headers to reduce redundancy and improve readability.
Replace Card component with SectionHeader for a simplified structure. Adjust layout to dynamically display worker data or a no-data message. Enhance visual hierarchy and readability of worker information.
This commit removes the `ConsultantOrEngineerHome` component along with its associated queries and header components. The page now redirects users based on their role type, simplifying the code structure.
Removed redundant class names from table headers in CasesTable.tsx for a cleaner codebase. Adjusted grid gap and margins in AllocationSection.tsx for better UI consistency.
Streamline the rendering of the CasesTable component by utilizing rowSpan and simplifying the structure. In the backend, improve worker grouping by sorting unique worker names and assigning them more clearly.
Remove unnecessary case activity check when building mapping of everhour project IDs to cases. Simplify the way inconsistencies are reported by directly appending them to the result list. This leads to cleaner and more readable code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.