Sync crypto-square #1320
Open
Sync crypto-square #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angelikatyborska I think it was people's implementations were just bad... I guess could look up some community solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One new test, plus I unskipped an existing test on CI and fixed the proof to pass that unskipped test. However, that test on the JS track has a comment: "This test doesn't run on our online test runner because it will time-out with most implementations. It's up to you to test your solution locally.". I don't think this exercise is in any way computation intensive 🤔 at least it wasn't on the Elixir track. If you remember what that was about, I can bring back the skip and add the same comment.