Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reverse String]: Add Approaches, Performance, and Unicode Articles #3609

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BethanyG
Copy link
Member

Added an Introduction.md and the Following Approaches:

  1. Sequence Slice with Negative Step
  2. Iteration with String Concatenation
  3. Reverse Iteration with Range()
  4. Make a list and Use str.join()
  5. Make a list and use list.reverse()
  6. Use the built-in reversed()
  7. Other interesting approaches

Also added:

  • Performance article,
  • Benchmark code
  • An article about working with Unicode strings outside of the ASCII range in Python (STUBBED currently)

Therefor != Therefore.  TIL.
Added missing link, so should no longer be broken.
@colinleach
Copy link
Contributor

This is remarkably good for something so long and complicated. I can see why it stressed you out for so long!

You already fixed the 2 minor things I found. I didn't see anything to comment on otherwise, and I think I've now read all of it.

Good luck with the Unicode article. I can't help you with that.

@BethanyG
Copy link
Member Author

Good luck with the Unicode article. I can't help you with that.

I am going to finish the Raindrops approaches (which aren't as good as these) and review Roman Numerals before looping back to this. You deserve to have your work merged, and it would be nice to hit the Raindrop deadline.

Thank you so much for giving this a review. It is such a relief to know that it wasn't absolutely bonkers. I am very happy that its good if long-winded & complicated. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants