parallel-letter-frequency: align requirements with test #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaMann
reviewed
Apr 27, 2022
| @@ -6,3 +6,7 @@ Parallelism is about doing things in parallel that can also be done | |||
| sequentially. A common example is counting the frequency of letters. | |||
| Create a function that returns the total frequency of each letter in a | |||
| list of texts and that employs parallelism. | |||
|
|
|||
| Uppercase letters count towards their lowercase equivalent. Support | |||
| at least the extended Latin character set, so that unicode "ü" is | |||
There was a problem hiding this comment.
There are (at least) two ways to write ü. Either as a combined character of u (U+0075) and ̈ (U+0308) or as ü (U+00FC). This difference has tripped me up in the past in another exercise. Does this require support of both those options? Might be good to be quite specific here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.