-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync tests for practice exercise markdown
#2615
Conversation
I guess to solve the tests failing I should update this function
So if the count is greater than 7 to output the input but in a paragraph, right? |
Yes, but don't update the one in |
Yeah I was going to update that one as well, but the goal of the exercise is that passes all test and students reformat the code, that's why I thought on updating |
Ah yes that's right, I forgot that this is a refactoring exercise. In that case you have to update both indeed. Sorry for the mixup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed the src/main/java/Markdown.java
file needs to be updated to reflect the new behavior as well.
…ation using again the <p> so the user can improve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙏
pull request
This issue addresses: #2388
The goal is to sync the tests of the markdown practice exercise
Reviewer Resources:
Track Policies