Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tests for practice exercise markdown #2615

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

manumafe98
Copy link
Contributor

pull request

This issue addresses: #2388

The goal is to sync the tests of the markdown practice exercise

Reviewer Resources:

Track Policies

@manumafe98
Copy link
Contributor Author

I guess to solve the tests failing I should update this function

private String parseHeader(String markdown) {

So if the count is greater than 7 to output the input but in a paragraph, right?

@sanderploegsma
Copy link
Contributor

I guess to solve the tests failing I should update this function

private String parseHeader(String markdown) {

So if the count is greater than 7 to output the input but in a paragraph, right?

Yes, but don't update the one in src/main/java, update the one in .meta/src/reference/java instead. The former is the stub file received by students, the latter is the reference implementation.

@manumafe98
Copy link
Contributor Author

Yeah I was going to update that one as well, but the goal of the exercise is that passes all test and students reformat the code, that's why I thought on updating src/main/java.

@sanderploegsma
Copy link
Contributor

Yeah I was going to update that one as well, but the goal of the exercise is that passes all test and students reformat the code, that's why I thought on updating src/main/java.

Ah yes that's right, I forgot that this is a refactoring exercise. In that case you have to update both indeed. Sorry for the mixup!

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed the src/main/java/Markdown.java file needs to be updated to reflect the new behavior as well.

…ation using again the <p> so the user can improve it
Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@sanderploegsma sanderploegsma merged commit 0081676 into exercism:main Jan 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants