Add queen-attack
#599
Merged
Add queen-attack
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
force-pushed
the
add-queen-attack
branch
from
91f7332
to
1ad0f6f
Compare
glennj
approved these changes
Oct 15, 2024
| group('Queen Attack', () { | ||
| group('Test creation of Queens with valid and invalid positions', () { | ||
| test('Queens with a valid position', () { | ||
| expect(() => Queen(2, 2), returnsNormally); |
There was a problem hiding this comment.
I haven't seen returnsNormally before. Nice.
Comment on lines
+6
to
+9
| : assert(row >= 0, 'row not positive'), | ||
| assert(row <= 7, 'row not on board'), | ||
| assert(column >= 0, 'column not positive'), | ||
| assert(column <= 7, 'column not on board'), |
There was a problem hiding this comment.
Yes, with the understanding that asserts are compiled out of production code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.