Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grains exercise #503

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add grains exercise #503

merged 4 commits into from
Nov 10, 2023

Conversation

BNAndras
Copy link
Member

No description provided.

@Stargator
Copy link
Contributor

@ErikSchierboom, just checking are we accepting new exercises? Or is that a new track decision?

@ErikSchierboom
Copy link
Member

@ErikSchierboom, just checking are we accepting new exercises? Or is that a new track decision?

I don't think so. The reason this PR wasn't auto-closed was that we have an expired token.

That said, the PR looks good. Are you happy to review or want me to do it?

@Stargator
Copy link
Contributor

I'm fine with reviewing it.

@Stargator
Copy link
Contributor

Sorry for the delay in this review.

Please update with the latest version of grains, they changed some of the wording. Already approved and I will merge it when the update is made.

@BNAndras
Copy link
Member Author

BNAndras commented Oct 16, 2023

 ./bin/configlet sync --metadata --docs --filepaths --tests include -uye grains
Updating cached 'problem-specifications' data...
Checking exercises...
The `grains` exercise has up-to-date docs, filepaths, metadata, and tests!

I don't see anything to update for grains. If I run configlet sync for all exercises, I see that acronym, allergies, armstrong-numbers, darts, isogram, and phone-number have unsynced docs.

@Stargator Stargator merged commit 2e0e7fb into exercism:main Nov 10, 2023
7 checks passed
@BNAndras BNAndras deleted the add-grains-exercise branch November 10, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants