Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change references for bats to point to bats-core #439

Closed
wants to merge 3 commits into from
Closed

Conversation

bkhl
Copy link
Contributor

@bkhl bkhl commented May 27, 2020

Looks like we had a forgotten branch from January where we started changing references to Bats to link to https://github.com/bats-core/bats-core

Added another commit to it and changing a few more references, prompted by #438

glennj and others added 3 commits January 18, 2020 10:22
Fedora 30 and up has bats in the official repo.
Changed all references to `sstephenson/bats` to `bats-core/bats-core`.

Closes #438
@bkhl bkhl requested a review from kotp May 27, 2020 08:08
@kotp
Copy link
Member

kotp commented May 27, 2020

Are the tests using the new version of Bats? The changes look good, but might want to confirm it won't break with current tests.

@bkhl
Copy link
Contributor Author

bkhl commented May 27, 2020

It's what is used for https://github.com/exercism/bash-test-runner , and I've used it when mentoring for some time and had no issues.This merge request got confusing because I accidentally used the same branch name as last time. The first two commits here are actually merged already.

I'll close this and start over.

@bkhl bkhl closed this May 27, 2020
@bkhl bkhl deleted the use-bats-core branch May 27, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants