Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtensor template fix #52

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

jtramm
Copy link

@jtramm jtramm commented Jun 3, 2024

This is a workaround for newer versions of LLVM that are having some sort of interaction with xtensor that is causing issues. Notably, this will also affect the main development branch of OpenMC eventually, though is much more of a present issue for the OMP fork given our reliance on newer compilers.

The intertwined issues are a little hard to parse, but I'm gathering that the issue may be in xtensor itself rather than with LLVM, but I'm not 100% on that.

Thankfully, there is an easy workaround flag that can be passed to LLVM that fixes the error. I think we should add it in now so that our auto testing works again and I'll plan on checking manually now and then to see if the flag is still required or not (and/or if an update to the xtensor submodule fixes it).

See issues:

@jtramm jtramm requested a review from paulromano June 3, 2024 18:58
Copy link

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano merged commit b8cdee7 into openmp-target-offload Jun 3, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
unageek added a commit to polatory/polatory that referenced this pull request Nov 15, 2024
@gridley
Copy link

gridley commented Nov 28, 2024

Note: I was running into this tonight building openmc on my mac. the LLVM homebrew gives you now runs into this.

Note on the note: this flag is deprecated but it fixes the issue nonetheless.

clang++: warning: argument '-fno-relaxed-template-template-args' is deprecated [-Wdeprecated-no-relaxed-template-template-args]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants