test(esl-toggleable): cover dispatcher with tests#1811
Open
test(esl-toggleable): cover dispatcher with tests#1811
Conversation
fshovchko
requested review from
ala-n,
dshovchko and
yadamskaya
and removed request for
a team
15 tasks
15 tasks
fshovchko
requested review from
HenadzV,
NastaLeo,
Natalie-Smirnova,
abarmina and
julia-murashko
ala-n
reviewed
Jul 28, 2023
Collaborator
ala-n
left a comment
ala-n
left a comment
There was a problem hiding this comment.
Consider a more isolated way of tasting.
Consider the ESLTogglableDispatcher as a component with an open event-based API.
So please think about creating a mock event and toggleable instances.
It sounds better to have integration testing simplified to the most important cases only and to be separated from more detailed unit tests of ESLToggleableDispatcher
ala-n
force-pushed
the
main
branch
6 times, most recently
from
1f18a8a to
6506db7
Compare
|
Code Climate has analyzed commit 299cc9c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 50.3% (1.0% change). View more on Code Climate. |
ala-n
force-pushed
the
main
branch
4 times, most recently
from
df09192 to
5f44df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of 50% voverage goal #1786