GenerateDataKeyWithoutPlaintext now does not send KeySpec when sending NumberOfBytes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mberOfBytes
This behavior is now consistent with GenerateDataKey and fixes `GenerateDataKeyWithoutPlaintext` with a `NumberOfBytes` specified causing KMS to return `{"ValidationException", "Please specify either number of bytes or key spec."}`.
|
Thanks, @stevegrossi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on
ex_aws_kms, I hope this contribution is helpful and I'd be grateful for any feedback on it.The Issue
I've run into an apparent issue when calling
ExAws.KMS.generate_data_key_without_plaintext(number_of_bytes: 128): the response returned is{"ValidationException", "Please specify either number of bytes or key spec."}. That function adds a default"KeySpec"even when"NumberOfBytes"is provided in the options. Per the docs, AWS KMS expects a"KeySpec"or a"NumberOfBytes"but not both:The Fix
ExAws.KMS.generate_data_keyavoids this issue by only adding the default"KeySpec"when"NumberOfBytes"is not given. This pull request applies that same approach toExAws.KMS.generate_data_key_without_plaintextand adds a test to confirm it.