Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default case #387

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

shadowwingz
Copy link

The onMenuItemClick function is missing the default case, and a warning will be reported in Android Studio.

@@ -115,6 +115,8 @@ public boolean onMenuItemClick(MenuItem menuItem) {
case SCROLL_ROW:
mTableView.scrollToRowPosition(5);
break;
default:
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you return false here? Same in the other file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, false should be returned here. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants