Skip to content

Update validator.js to not allow length 0 & indels#10

Open
ShreyaKakhandiki wants to merge 1 commit intoevoldoers:mainfrom
ShreyaKakhandiki:patch-2
Open

Update validator.js to not allow length 0 & indels#10
ShreyaKakhandiki wants to merge 1 commit intoevoldoers:mainfrom
ShreyaKakhandiki:patch-2

Conversation

@ShreyaKakhandiki
Copy link
Contributor

Added a check in traverseTree to throw an error if a branch with length zero contains indels (evolutionarily impossible)

…ength 0

Added a check in traverseTree to throw an error if a branch with length zero contains indels (evolutionarily impossible)
@ihh
Copy link
Member

ihh commented Aug 4, 2025

Looks good. Suggest you remove the console.log("DISTANCE HERE IS ZERO") since a validator shouldn't print log messages but should just silently report back to its caller whether (and how) the data format is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants