forked from mixxxdj/mixxx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPPING - test PR 2.4 Roland DJ 202 (Do not merge) #7
Draft
evoixmr
wants to merge
125
commits into
evoixmr:2.4-testing
Choose a base branch
from
Lykos153:Mapping-DJ-202
base: 2.4-testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value could never become true, and all full scale "controls"/processControl were handled by the expensive "bitvector"/processButton code
Corrected the output offset numbers. The 1st byte with the ReportID were not taken into account
Fixes for hid-parser and Traktor F1 script
Pioneer DDJ-FX4: Add waveform zoom
Adjust the taglib1 lookup path for archlinux
History: show track count and duration in sidebar
avoids hitting DEBUG_ASSERT when removing tracks from a locked crate
Hercules Inpulse 200 - Configure shift-browser knob to scroll the library (quick)
…-fix (fix) TrackModel remove tracks
bg color was overlapping defined area because of wrong qss selector
Pull Request Test Coverage Report for Build 8319522640Details
💛 - Coveralls |
On Mixxx 2.3, Sync buttons were toggling Sync lock with a long press, and one time sync with a short press. This commit restores this with Mixxx 2.4 (before, the sync buttons did only one-time sync, but a long press did nothing).
Headphones gain and headphones mix (commonly known as Cue mix) knobs now interact on Mixxx's GUI (previously, they worked, but on-screen knobs didn't move).
See: mixxxdj#1595 (comment) Co-authored-by: JoergAtGithub <[email protected]>
Cue buttons didn't work like they should. Corrected.
- removed superfluous comment - added comment for button flash timeout
Solved the issue for FX buttons not lighting up when FX are activated.
Re MIDI learnt sync/sync lock to ensure proper function
Updated authors (I've used Claude AI to solve the FX buttons not keep lighting up issue)
Came back to last version edited by evoixmr to avoid copyright issues.
rollback to previous versions edited by evoixmr
changed my author name with pseudonym only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAPPING
Mapping official PR - mixxxdj#1595
Mapping Test PR - #7
Mapping JS - https://github.com/Lykos153/mixxx/blob/Mapping-DJ-202/res/controllers/Roland_DJ-202-scripts.js
Mapping XML - https://github.com/Lykos153/mixxx/blob/Mapping-DJ-202/res/controllers/Roland_DJ-202.midi.xml
MANUAL
Manual official PR - mixxxdj/manual#629
Preview: https://deploy-preview-629--mixxx-manual.netlify.app/hardware/controllers/roland_dj_202
Manual Test PR - evoixmr/manual#8
Manual draft (base on wiki) - https://github.com/evoixmr/manual/blob/2.4-Roland-DJ-202/source/hardware/controllers/roland_dj_202.rst
MISC LINKS
Forum thread - https://mixxx.discourse.group/t/mapping-the-roland-rj-202/17099/72
Wiki - https://github.com/mixxxdj/mixxx/wiki/Roland-Dj-202
Manufacturer's product page - https://www.roland.com/global/products/dj-202/
GUIDE
Roland DJ 505