Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPPING - test PR 2.4 Roland DJ 202 (Do not merge) #7

Draft
wants to merge 125 commits into
base: 2.4-testing
Choose a base branch
from

Conversation

daschuer and others added 30 commits February 28, 2024 19:54
…value could never become true, and all full scale "controls"/processControl were handled by the expensive "bitvector"/processButton code
Corrected the output offset numbers. The 1st byte with the ReportID were not taken into account
Fixes for hid-parser and Traktor F1 script
Adjust the taglib1 lookup path for archlinux
History: show track count and duration in sidebar
avoids hitting DEBUG_ASSERT when removing tracks from a locked crate
Hercules Inpulse 200 - Configure shift-browser knob to scroll the library (quick)
bg color was overlapping defined area because of wrong qss selector
@coveralls
Copy link

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 8319522640

Details

  • 23 of 37 (62.16%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 39.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/library/trackset/setlogfeature.cpp 18 20 90.0%
src/widget/wtracktableview.cpp 0 3 0.0%
src/library/trackset/crate/cratetablemodel.cpp 0 9 0.0%
Totals Coverage Status
Change from base Build 8124242409: 0.01%
Covered Lines: 31233
Relevant Lines: 78283

💛 - Coveralls

@evoixmr evoixmr marked this pull request as draft March 15, 2024 14:45
evoixmr and others added 15 commits March 15, 2024 13:18
On Mixxx 2.3, Sync buttons were toggling Sync lock with a long press, and one time sync with a short press. This commit restores this with Mixxx 2.4 (before, the sync buttons did only one-time sync, but a long press did nothing).
Headphones gain and headphones mix (commonly known as Cue mix) knobs now interact on Mixxx's GUI (previously, they worked, but on-screen knobs didn't move).
Cue buttons didn't work like they should. Corrected.
- removed superfluous comment
- added comment for button flash timeout
Solved the issue for FX buttons not lighting up when FX are activated.
Re MIDI learnt sync/sync lock to ensure proper function
Updated authors (I've used Claude AI to solve the FX buttons not keep lighting up issue)
Came back to last version edited by evoixmr to avoid copyright issues.
rollback to previous versions edited by evoixmr
changed my author name with pseudonym only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.