Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hardcoded CPPCHECK_VERSION #620

Closed
wants to merge 1 commit into from
Closed

Remove the hardcoded CPPCHECK_VERSION #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ jobs:
luacheck:
name: Lint codebase
runs-on: ubuntu-24.04
env:
CPPCHECK_VERSION: 2.16.0
steps:

# LuaRocks needs the 5.1 headers to compile LuaCheck later, so we download them, too
Expand Down Expand Up @@ -56,13 +54,10 @@ jobs:
- name: Run selene
run: selene .

# apt only has an ancient version, which behaves inconsistently
- name: Install cppcheck
run: |
git clone --depth 1 https://github.com/danmar/cppcheck.git
cd cppcheck
git fetch --tags
git checkout $CPPCHECK_VERSION
mkdir build
cd build
cmake ..
Expand Down
Loading