-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: platform French support and Spanish fix #1469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 What's new
ILanguage
and all interface dependents interface to support FrenchOrder
entity lang support⚠ Warning:
Although FR language files have been added, some are only copies of the EN language. Unfortunately, I couldn't translate them even because I don't have the right tools for that :).
But I have a track to be able to quickly translate our language JSON files. By using JeffJorczak.auto-translate-json an extension of VsCode.
Here is the list of paths of FR JSON files that must be translated:
packages\admin-web-angular\src\assets\i18n\fr-FR.json
packages\merchant-tablet-ionic\src\assets\i18n\fr-FR.json
packages\shop-web-angular\src\assets\i18n\fr-FR.json
🌟Suggestion
I strongly suggest the integration mentioned in this Issue, it will help a lot!
🚧 Before this PR