Use erlang term format instead of ascii #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaothallis
reviewed
May 13, 2020
Closed
Apparently the [example on erlang.org](https://erlang.org/doc/tutorial/erl_interface.html) is wrong for specific lengths of packets...
|
Checked with Valgrind and everything seems nice. |
|
A test is failing on travis only, see #17. Otherwise tests are OK. |
Also: - Adds `GenMagic.Server.recycle` and `GenMagic.Server.reload` which allows to restart/reload the apprentice server with a new set of databases, - Fix compilation on musl based distributions (was caused by the args code), - Handle timeouts better in `GenMagic.Server` - Force the port to close in recycling if the graceful stop timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
apprentice.cto use the erl_interface/ei.h instead of ascii.Probably also fixes a possible buffer overflow in the old process_line, and will work with the maximum path length (4096).
Magic errors now try to uses
magic_errnoto have more generic errors (for example, my libmagic wasn't returning the same string as yours ("unable to access file").perform/3calls now support passing a binary instead of a file path ({:bytes, ...}).The databases are now loaded by using message passing and not arguments.
Added
GenMagic.Server.recycleandGenMagic.Server.reloadwhich allows to manually recycle/reload the port, and also loading a new set of databases.Fixes building on musl (was related to the arguments code, see #16, #18).
Handle timeouts a bit nicer in server.
Handle a recycle stop timeout by forcing the port close.
Added tests dedicated to the port.
Tested on: MacOS, FreeBSD, Alpine, Ubuntu, Debian, Fedora, Voidlinux. TODO: Open/Net BSD.