Skip to content

Commit

Permalink
Feat/multi presentations (#84)
Browse files Browse the repository at this point in the history
* Adaptations to handle the fact that vp_token is now an array of presentations

* - Restructured features and components, clean up code
- Introduced registry of attestation decoders per format (currently supporting mso_mdoc and jwt_vc_json)

* - Restructured features and components, clean up code
- Introduced registry of attestation decoders per format (currently supporting mso_mdoc and jwt_vc_json)

* Clean ups

* Clean up routes, fix wallet-redirect feature
  • Loading branch information
vafeini authored Sep 30, 2024
1 parent 0f7535a commit 5d7fc08
Show file tree
Hide file tree
Showing 113 changed files with 2,019 additions and 1,742 deletions.
137 changes: 137 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
# Contributor Covenant Code of Conduct

## Our Pledge

We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
size, visible or invisible disability, ethnicity, sex characteristics, gender
identity and expression, level of experience, education, socio-economic status,
nationality, personal appearance, race, religion, or sexual identity
and orientation.

We pledge to act and interact in ways that contribute to an open, welcoming,
diverse, inclusive, and healthy community.

## Our Standards

Examples of behavior that contributes to a positive environment for our
community include:

* Demonstrating empathy and kindness toward other people
* Being respectful of differing opinions, viewpoints, and experiences
* Giving and gracefully accepting constructive feedback
* Accepting responsibility and apologizing to those affected by our mistakes,
and learning from the experience
* Focusing on what is best not just for us as individuals, but for the
overall community

Examples of unacceptable behavior include:

* The use of sexualized language or imagery, and sexual attention or
advances of any kind
* Trolling, insulting or derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or email
address, without their explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Enforcement Responsibilities

Community leaders are responsible for clarifying and enforcing our standards of
acceptable behavior and will take appropriate and fair corrective action in
response to any behavior that they deem inappropriate, threatening, offensive,
or harmful.

Community leaders have the right and responsibility to remove, edit, or reject
comments, commits, code, wiki edits, issues, and other contributions that are
not aligned to this Code of Conduct, and will communicate reasons for moderation
decisions when appropriate.

## Scope

This Code of Conduct applies within all community spaces, and also applies when
an individual is officially representing the community in public spaces.
Examples of representing our community include using an official e-mail address,
posting via an official social media account, or acting as an appointed
representative at an online or offline event.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported at [[email protected]](mailto:[email protected]).
to the community leaders responsible for enforcement.

All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
reporter of any incident.

## Enforcement Guidelines

Community leaders will follow these Community Impact Guidelines in determining
the consequences for any action they deem in violation of this Code of Conduct:

### 1. Correction

**Community Impact**: Use of inappropriate language or other behavior deemed
unprofessional or unwelcome in the community.

**Consequence**: A private, written warning from community leaders, providing
clarity around the nature of the violation and an explanation of why the
behavior was inappropriate. A public apology may be requested.

### 2. Warning

**Community Impact**: A violation through a single incident or series
of actions.

**Consequence**: A warning with consequences for continued behavior. No
interaction with the people involved, including unsolicited interaction with
those enforcing the Code of Conduct, for a specified period of time. This
includes avoiding interactions in community spaces as well as external channels
like social media. Violating these terms may lead to a temporary or
permanent ban.

### 3. Temporary Ban

**Community Impact**: A serious violation of community standards, including
sustained inappropriate behavior.

**Consequence**: A temporary ban from any sort of interaction or public
communication with the community for a specified period of time. No public or
private interaction with the people involved, including unsolicited interaction
with those enforcing the Code of Conduct, is allowed during this period.
Violating these terms may lead to a permanent ban.

### 4. Permanent Ban

**Community Impact**: Demonstrating a pattern of violation of community
standards, including sustained inappropriate behavior, harassment of an
individual, or aggression toward or disparagement of classes of individuals.

**Consequence**: A permanent ban from any sort of public interaction within
the community.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage],
version 2.0, available at
[https://www.contributor-covenant.org/version/2/0/code_of_conduct.html][v2.0].

Community Impact Guidelines were inspired by
[Mozilla's code of conduct enforcement ladder][Mozilla CoC].

For answers to common questions about this code of conduct, see the FAQ at
[https://www.contributor-covenant.org/faq][FAQ]. Translations are available
at [https://www.contributor-covenant.org/translations][translations].

[homepage]: https://www.contributor-covenant.org

[v2.0]: https://www.contributor-covenant.org/version/2/0/code_of_conduct.html

[Mozilla CoC]: https://github.com/mozilla/diversity

[FAQ]: https://www.contributor-covenant.org/faq

[translations]: https://www.contributor-covenant.org/translations
113 changes: 113 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
# Contribution Guidelines

We welcome contributions to this project. To ensure that the process is smooth for everyone
involved, please follow the guidelines below.

If you encounter a bug in the project, check if the bug has already been reported. If the
bug has not been reported, you can open an issue to report the bug.

Before making any changes, it's a good practice to create an issue to describe the changes
you plan to make and the reasoning behind them.

You can
read [Finding ways to contribute to open source on GitHub](https://docs.github.com/en/get-started/exploring-projects-on-github/finding-ways-to-contribute-to-open-source-on-github)
for more information.

## GitHub Flow

We use the [GitHub Flow](https://guides.github.com/introduction/flow/) workflow for making
contributions to this project. This means that:

1. Fork the repository and create a new branch from `main` for your changes.

```bash
git checkout main
git pull
git checkout -b my-branch
```

2. Make changes to the code, documentation, or any other relevant files.
3. Commit your changes and push them to your forked repository.

```bash
git add .
git commit -m "Add a new feature"
git push origin my-branch
```

4. Create a pull request from your branch to the `main` branch of this repository.

## Pull Request Checklist

* Branch from the main branch and, if needed, rebase to the current main branch before submitting
your pull request. If it doesn't merge cleanly with main you may be asked to rebase your changes.
* Commits should be as small as possible while ensuring that each commit is correct independently (
i.e., each commit should compile and pass tests).
* Test your changes as thoroughly as possible before you commit them. Preferably, automate your test
by unit/integration tests. If tested manually, provide information about the test scope in the PR
description (e.g. “Test passed: Upgrade version from 0.42 to 0.42.23.”).
* Create _Work In Progress [WIP]_ pull requests only if you need clarification or an explicit review
before you can continue your work item.
* If your patch is not getting reviewed or you need a specific person to review it, you can @-reply
a reviewer asking for a review in the pull request or a comment.
* Post review:
* If a review requires you to change your commit(s), please test the changes again.
* Amend the affected commit(s) and force push onto your branch.
* Set respective comments in your GitHub review to resolved.
* Create a general PR comment to notify the reviewers that your amendments are ready for another
round of review.
## Branch Name Rules
Please name your branch using the following convention:
```text
<type>/<short-description>
```
- `type` should be one of the following:
- `feat` for a new feature,
- `fix` for a bug fix,
- `docs` for documentation changes,
- `style` for changes that do not affect the code, such as formatting or whitespace,
- `refactor` for code refactoring,
- `test` for adding or updating tests, or
- `chore` for any other miscellaneous tasks.
- `short-description` should be a short, descriptive name of the changes you are making.
For example:
```text
feat/add-new-button
fix/typo-in-readme
docs/update-contributing-guide
style/format-code
refactor/extract-method
test/add-unit-tests
chore/update-dependencies
```
## Issues and Planning
* We use GitHub issues to track bugs and enhancement requests.
* Please provide as much context as possible when you open an issue. The information you provide
must be comprehensive enough to reproduce that issue for the assignee. Therefore, contributors may
use but aren't restricted to the issue template provided by the project maintainers.

* When creating an issue, try using one of our issue templates which already contain some guidelines
on which content is expected to process the issue most efficiently. If no template applies, you
can of course also create an issue from scratch.

* Please apply one or more applicable [labels](/../../labels) to your issue so that all community
members are able to cluster the issues better.

## Code of Conduct

Please note that this project is released with a [Contributor Code of Conduct](CODE_OF_CONDUCT.md).
By participating in this project, you agree to abide by its terms.
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@
"@codemirror/lang-json": "^6.0.1",
"@types/codemirror": "^5.60.7",
"@types/crypto-js": "^4.1.1",
"@types/uuid": "10.0.0",
"bignumber.js": "^9.1.2",
"buffer": "^6.0.3",
"cbor-bigdecimal": "^9.0.0",
"cbor-web": "8.0.1",
"cbor-x": "^1.6.0",
"codemirror": "^6.0.1",
"crypto-js": "^4.1.1",
"jsonpath-plus": "^9.0.0",
"jwt-decode": "3.1.2",
"nofilter": "^4.0.2",
"qrcodejs": "^1.0.0",
Expand All @@ -54,6 +55,7 @@
"@angular/compiler-cli": "^15.2.9",
"@types/jasmine": "~4.3.0",
"@types/jest": "^29.5.10",
"@types/node": "^22.6.1",
"@typescript-eslint/eslint-plugin": "5.48.2",
"@typescript-eslint/parser": "5.48.2",
"cypress": "^12.10.0",
Expand Down
43 changes: 14 additions & 29 deletions src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
@@ -1,46 +1,31 @@
import { NgModule } from '@angular/core';
import { PreloadAllModules, RouterModule, Routes } from '@angular/router';
import { WalletRedirectResolver } from './features/wallet-redirect/resolver/wallet-redirect-resolver';
import { PresentationDefinitionService } from './core/services/presentation-definition.service';
import { CborDecodeService } from './core/services/cbor/cbor-decode.service';
import { JWTService } from './core/services/jwt.service';
import { NavigateService } from './core/services/navigate.service';
import {NgModule} from '@angular/core';
import {PreloadAllModules, RouterModule, Routes} from '@angular/router';
import {WalletRedirectResolver} from '@features/wallet-redirect/resolver/wallet-redirect-resolver';
import {NavigateService} from '@core/services/navigate.service';
import {VerifierEndpointService} from "@core/services/verifier-endpoint.service";

const routes: Routes = [
{ path: '', redirectTo: 'home', pathMatch: 'full' },
{ path: 'home', loadComponent: () => import('./features/home/components/home/home.component').then(c => c.HomeComponent) },
{ path: 'custom-request',
loadChildren: () => import('./features/presentation-definition/presentation-definition.module').
then(m => m.PresentationDefinitionModule )},
// { path: 'siop',
// loadChildren: () => import('./features/siop/siop.module').
// then(m => m.SIOPModule )},
{ path: 'pid-full',
loadChildren: () => import('./features/cbor/cbor.module').
then(m => m.CborModule )},
{ path: 'cbor-selectable',
loadChildren: () => import('@features/custom-presentation-request/custom-presentation-request.module').
then(m => m.CustomPresentationRequestModule )},
{ path: 'selectable',
loadChildren: () => import('@features/selectable-presentation/selectable-presentation.module').
then(m => m.SelectablePresentationModule )},
{ path: 'pid-age-over-18',
loadChildren: () => import('./features/cbor/cbor.module').
then(m => m.CborModule )
},
{ path: 'age-attestation',
loadChildren: () => import('./features/cbor/cbor.module').
then(m => m.CborModule )
then(m => m.SelectablePresentationModule )
},
{ path: 'invoke-wallet',
loadChildren: () => import('@features/invoke-wallet/invoke-wallet.module').
then(m => m.InvokeWalletModule)
},
{ path: 'mdl-selectable',
loadChildren: () => import('@features/selectable-presentation/selectable-presentation.module').
then(m => m.SelectablePresentationModule ),
},
{ path: 'mdl-full',
loadChildren: () => import('./features/cbor/cbor.module').
then(m => m.CborModule )
},
{
path: 'get-wallet-code',
loadComponent: () => import('./features/wallet-redirect/wallet-redirect.component').then(c => c.WalletRedirectComponent),
providers: [PresentationDefinitionService, CborDecodeService, JWTService, NavigateService],
providers: [VerifierEndpointService, NavigateService],
resolve: {
data: WalletRedirectResolver
}
Expand Down
3 changes: 2 additions & 1 deletion src/app/core/constants/constants.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export const UI_PRESENTATION = 'UI_PRESENTATION';
export const ACTIVE_TRANSACTION = 'ACTIVE_TRANSACTION';
export const ACTIVE_PRESENTATION_DEFINITION = 'ACTIVE_PRESENTATION_DEFINITION';
export const SCHEME = 'scheme';
export const DEFAULT_SCHEME = 'eudi-openid4vp://';
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ActionCode } from '@app/shared/elements/body-actions/models/ActionCode';
import { BodyAction } from '@app/shared/elements/body-actions/models/BodyAction';
import { ActionCode } from '@shared/elements/body-actions/models/ActionCode';
import { BodyAction } from '@shared/elements/body-actions/models/BodyAction';

export const HOME_ACTIONS: BodyAction[] = [
{
Expand All @@ -12,7 +12,7 @@ export const HOME_ACTIONS: BodyAction[] = [
code: ActionCode.NEXT
}
];
export const CBOR_ACTIONS: BodyAction[] = [
export const SELECTABLE_ACTIONS: BodyAction[] = [
{
label: 'Next',
id: 'next_button',
Expand Down
Loading

0 comments on commit 5d7fc08

Please sign in to comment.