Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake target libraries and linking so plugins work #667

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix cmake target libraries and linking so plugins work #667

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0ef762
Fix cmake target libraries and linking so plugins work
Apr 13, 2021
89a926d
Add linking of mav_proto_msgs to gazebo_ros_interface plugin as I mis…
Apr 14, 2021
38800dc
Merge branch 'master' of https://github.com/ethz-asl/rotors_simulator…
jlack1987 Apr 20, 2021
9d0e102
Forgot to add the mav_proto_msgs to the list of installed targets
Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions rotors_gazebo_plugins/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,9 @@ file(GLOB msgs msgs/*.proto)
PROTOBUF_GENERATE_CPP(PROTO_SRCS PROTO_HDRS ${msgs})

# Create a shared library of protobuf messages (.so extension on Linux platforms)
add_library(mav_msgs SHARED ${PROTO_SRCS})
target_link_libraries(mav_msgs ${PROTOBUF_LIBRARY} gazebo_msgs)

# This causes mav_msgs to be linked with every created library in this file from this
# point forward.
# NOTE: This is deprecated, should be using target_link_libraries instead
link_libraries(mav_msgs)
add_library(mav_proto_msgs SHARED ${PROTO_SRCS})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you not rename the package? This would need to propagate further than just this cmake file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't rename a package. It renames the cmake library created for the protobuf msgs

target_link_libraries(mav_proto_msgs ${PROTOBUF_LIBRARY} gazebo_msgs)
list(APPEND targets_to_install mav_proto_msgs)

# ============================================== #
# ==================== CATKIN ================== #
Expand Down Expand Up @@ -245,6 +241,7 @@ if (NOT NO_ROS)
set(target_linking_LIBRARIES ${catkin_LIBRARIES} ${GAZEBO_LIBRARIES})
endif()
endif()
list(APPEND target_linking_LIBRARIES mav_proto_msgs)


# Including GAZEBO_MSG_INCLUDE_DIRS here allows the .cpp files generated by custom .proto files to find
Expand Down