Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rviz config #27

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Update rviz config #27

merged 1 commit into from
Nov 13, 2023

Conversation

srmainwaring
Copy link
Contributor

Update the rviz config for the ros2 branch.

  • Move rviz config to a separate directory and update cmake install.
  • Resaving the config file appears to fix the issue where the map was not visible on initial load.

@srmainwaring
ros2: update rviz config
36dad88 
Signed-off-by: Rhys Mainwaring <[email protected]>
Jaeyoung-Lim
Jaeyoung-Lim approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Jaeyoung-Lim Jaeyoung-Lim merged commit ef21a5d into ethz-asl:ros2 Nov 13, 2023
0 of 3 checks passed
@srmainwaring srmainwaring deleted the prs/pr-rviz-config branch November 14, 2023 20:42
@srmainwaring srmainwaring mentioned this pull request Nov 15, 2023
Closed
8 tasks
@Jaeyoung-Lim Jaeyoung-Lim mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Jaeyoung-Lim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srmainwaring @Jaeyoung-Lim