Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to humble #24

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Port to humble #24

merged 2 commits into from
Oct 30, 2023

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Oct 23, 2023

This has all the changes I made to port to humble. This duplicates other work, however there are unique pieces that can be covered.

@Jaeyoung-Lim
Copy link
Member

@Ryanf55 Could you switch the base branch of the PR to https://github.com/ethz-asl/grid_map_geo/tree/ros2 ? Then would be easier for the relevant diff

@Ryanf55 Ryanf55 changed the base branch from master to ros2 October 24, 2023 02:03
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 24, 2023

@Ryanf55 Could you switch the base branch of the PR to https://github.com/ethz-asl/grid_map_geo/tree/ros2 ? Then would be easier for the relevant diff

Done! I'll have to fix merge conflicts now, but it should give you the basic idea.

Signed-off-by: Ryan Friedman <[email protected]>
* Update docs
* Remove ROS1 cruft

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 25, 2023

I've fixed merge conflicts. Ready for review.

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks! Looks good for me!

@Jaeyoung-Lim
Copy link
Member

Realized that the build test of ROS Noetic should not be valid for this branch anymore. Will address in a follow up PR

@Ryanf55 Should we make the ros2 branch the default? or would you prefer a separate repository? I can also create a grid_map_geo2 under the ASL org if you prefer this way

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 26, 2023

Realized that the build test of ROS Noetic should not be valid for this branch anymore. Will address in a follow up PR

@Ryanf55 Should we make the ros2 branch the default? or would you prefer a separate repository? I can also create a grid_map_geo2 under the ASL org if you prefer this way

I've generally seen just updating ros2 to be the default. Since the code is largely the same, people still use ROS1, having it all in one repo makes backports easier. I don't have a strong preference.

@Jaeyoung-Lim Jaeyoung-Lim merged commit 6eea0ef into ethz-asl:ros2 Oct 30, 2023
0 of 3 checks passed
@srmainwaring srmainwaring mentioned this pull request Nov 15, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants