fix: remove isValue as it is not needed #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xCardinalError
changed the title
nugaon
approved these changes
Jul 2, 2024
0xCardinalError
force-pushed
the
remove_isValue
branch
from
9f58ca7 to
27936de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using isValue in struct as a check if there is some value in struct, but it's obsolete, as solidity, has default values for values that are not set, so we can use "lastUpdatedBlockNumber" check to see if it is zero, as it will be zero just when staking is not ever added, the first time it is, it will have value and will always have some value in future, which is what we wanted with isValue in first place.