Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces fixes and new lookup functionality for leaderboard endpoints along with a new slot lookup endpoint, and enhances caching for various leaderboard queries.
- Added a new ListDetailsRow type and getListDetailsBySlot service method for slot lookup.
- Updated leaderboard endpoints to use pagination and caching consistently.
- Introduced a new slots router and endpoint.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/service/efp-indexer/service.ts | Added new ListDetailsRow type and getListDetailsBySlot to fetch list details by slot; updated leaderboard rank mapping to convert rank from string to number. |
| src/router/api/v1/slots/index.ts | Added new router for slot-related endpoints. |
| src/router/api/v1/slots/details/index.ts | Added details endpoint to retrieve slot details with caching logic. |
| src/router/api/v1/leaderboard/mutes/index.ts | Updated mutes endpoint; however, there is a potential cache key misassignment. |
| src/router/api/v1/leaderboard/muted/index.ts | Updated muted endpoint to use pagination and caching. |
| src/router/api/v1/leaderboard/following/index.ts | Updated following endpoint to use pagination and caching. |
| src/router/api/v1/leaderboard/followers/index.ts | Updated followers endpoint to use pagination and caching. |
| src/router/api/v1/leaderboard/count/index.ts | Updated count endpoint to include caching. |
| src/router/api/v1/leaderboard/blocks/index.ts | Updated blocks endpoint to use pagination and caching. |
| src/router/api/v1/leaderboard/blocked/index.ts | Updated blocked endpoint to use pagination and caching. |
| src/router/api/v1/index.ts | Routed new slots endpoints along with reorganizing the API endpoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leaderboard endpoints, service, cache