Tiny Correction for returndata in Create #881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the definition of z above, where it is 0 in the error case, I think it should be z = 0 instead of z = 1. Alternatively, it could simplified as
```
$\boldsymbol{\mu}'_{\mathbf{o}} = \mathbf{o}$
```
|
This bit of the YP is not very clear, but I think the logic is that the output is returned in the case of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the definition of z above, where it is
z = 0in the error case, I think it should bez = 0instead ofz = 1in this part as well. Alternatively, the whole line could simplified as