core/stateless: cap witness depth metrics buckets #33389
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/stateless/stats.go
Outdated
| // The last path is always a leaf. | ||
| if i == len(paths)-1 || !strings.HasPrefix(paths[i+1], paths[i]) { | ||
| depth := len(path) | ||
| if depth >= len(s.accountTrieLeaves) { |
Member
There was a problem hiding this comment.
pls cap the length according to the type, use accountTrieLeaves or storageTrieLeaves accordingly
Contributor
Author
There was a problem hiding this comment.
pls cap the length according to the type, use
accountTrieLeavesorstorageTrieLeavesaccordingly
corrected, should I add a test?
rjl493456442
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WitnessStats.Add was indexing fixed-size depth arrays directly by len(path), where path is the trie node prefix in nibbles. For state and storage tries these prefixes can easily exceed 15, which makes the index out of range for the [16]int64 backing arrays and causes a panic when collecting witness statistics. This change clamps the computed depth to the last bucket (15+) so that all deeper leaves are still counted without risking an out-of-bounds access, while preserving the existing 0..15 metrics layout.