trie: optimize parallel trie committer #33385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NodeSet merges until after goroutine synchronization
Member
Author
|
@floor-licker I opened it here for benchmarking. Feel free to reopen a new PR under your account! |
Member
Author
|
It's deployed on 7/8. 7 is around 30 minutes ahead before the benchmark. |
Member
Author
|
Bench07 is the PR, it doesn't show any significant speedup by applying the change. Instead the account trie commit is somehow slightly slower. 
|
Member
Author
|
Unfortunately the benchmark shows there is no noticeable improvement in terms of trie commit, close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's authored by @floor-licker