Skip to content

Conversation

raxhvl
Copy link
Member

@raxhvl raxhvl commented Sep 9, 2025

πŸ—’οΈ Description

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@raxhvl raxhvl changed the title ✨ feat(EIP-7928): OOG: Intrinsic gas ✨ feat(test): EIP-7928 OOG test cases Sep 9, 2025
@raxhvl raxhvl self-assigned this Sep 9, 2025
@raxhvl raxhvl added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Sep 9, 2025
@raxhvl raxhvl changed the title ✨ feat(test): EIP-7928 OOG test cases ✨ feat(tests): EIP-7928 OOG test cases Sep 9, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the test and I think the approach has to be modified since the intrinsic gas cost exception is going to happen earlier in the checks than any BAL processing, so there won't be any BAL logic to check for.

My suggestion would be to refactor these tests so that there is enough intrinsic gas but the test runs OOG during the EVM execution (maybe after modification of the state via SSTORE or other means, e.g. code deployment, self-destructs, etc.).

Comment on lines 42 to 43
alice = pre.fund_eoa(amount=1_000_000)
bob = pre.fund_eoa(amount=100)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this naming btw - just wanted to say :)

@raxhvl raxhvl force-pushed the feat/eip-7928/tests branch from 780a23e to c89d947 Compare September 15, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants