-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forks,tests): EIP-2935: Contract update #1046
Conversation
38f910b
to
aef40be
Compare
Both EIP PR and execution-specs PR have been merged, we should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tests/prague/eip2935_historical_block_hashes_from_state/test_contract_deployment.py
Outdated
Show resolved
Hide resolved
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Show resolved
Hide resolved
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a test where it is deployed
mine a few blocks
then we call the contract
…ontract_deployment.py Co-authored-by: danceratopz <[email protected]>
4ffc823
to
a272989
Compare
* feat(forks,tests): EIP-2935: Contract update * Update tests/prague/eip2935_historical_block_hashes_from_state/test_contract_deployment.py Co-authored-by: danceratopz <[email protected]> * fix: Add storage hint * refactor(tools): Use `Block` instead of `Tuple` * fix(tools): pass test_type * new(tests): Add block hash checking on deployment test --------- Co-authored-by: danceratopz <[email protected]>
🗒️ Description
Update tests for EIP-2935 to match the following spec updates:
🔗 Related Issues
#956
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.