Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forks,tests): EIP-2935: Contract update #1046

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 30, 2024

🗒️ Description

Update tests for EIP-2935 to match the following spec updates:

🔗 Related Issues

#956

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore labels Dec 30, 2024
@marioevz marioevz force-pushed the eip-2935-contract-update branch 2 times, most recently from 38f910b to aef40be Compare January 9, 2025 16:43
@marioevz marioevz requested a review from danceratopz January 9, 2025 16:43
@marioevz
Copy link
Member Author

marioevz commented Jan 9, 2025

Both EIP PR and execution-specs PR have been merged, we should be good to merge.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a test where it is deployed
mine a few blocks
then we call the contract

@marioevz marioevz force-pushed the eip-2935-contract-update branch from 4ffc823 to a272989 Compare January 10, 2025 18:58
@marioevz marioevz merged commit 76069fe into main Jan 10, 2025
21 checks passed
@marioevz marioevz deleted the eip-2935-contract-update branch January 10, 2025 19:11
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
* feat(forks,tests): EIP-2935: Contract update

* Update tests/prague/eip2935_historical_block_hashes_from_state/test_contract_deployment.py

Co-authored-by: danceratopz <[email protected]>

* fix: Add storage hint

* refactor(tools): Use `Block` instead of `Tuple`

* fix(tools): pass test_type

* new(tests): Add block hash checking on deployment test

---------

Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants