Fix build failure when Salesforce credentials unavailable #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Centralized Salesforce credential management to prevent exposure - Added pre-flight file size validation to prevent DOS attacks - Implemented numeric field sanitization for data integrity - Enhanced error handling with structured JSON responses - Added credential validation with fail-fast pattern - Upgraded critical error logging for monitoring systems Resolves security vulnerabilities and data integrity issues across 6 API endpoints without introducing race conditions or memory leaks.
Fixes build failures when SF credentials are not configured by gracefully returning empty array in getGrantInitiativeItems(). This allows: - CI/CD builds without credentials - Local development builds - Static site generation with fallback: 'blocking' to generate pages at runtime The pages use ISR (Incremental Static Regeneration) with fallback: 'blocking', so pages will be generated on first request when credentials are available.
anuragchvn-blip
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
👷 Deploy request for ecosystem-support pending review.Visit the deploys page to approve it
|
Author
|
@pettinarip Would appreciate your review on this fix. This resolves build failures when Salesforce credentials aren't configured, which blocks CI/CD and local development builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes build failures when Salesforce credentials are not configured by gracefully returning empty array in
getGrantInitiativeItems().Changes
getGrantInitiativeItems()to return empty array when credentials missingfallback: 'blocking'to generate on first request when credentials availableImpact
Testing
Verified
npm run buildsucceeds with: